Skip to content

Add INI Parser library#149

Merged
yetalit merged 7 commits intomodular:mainfrom
Hammad-hab:add/mojo-ini
Jul 12, 2025
Merged

Add INI Parser library#149
yetalit merged 7 commits intomodular:mainfrom
Hammad-hab:add/mojo-ini

Conversation

@Hammad-hab
Copy link
Copy Markdown
Contributor

Checklist

  • My recipe.yaml file specifies which version(s) of MAX is compatible with my project (see here for an example). If not, my package is compatible with both 24.5 and 24.6.
  • License file is packaged (see here for an example).
  • Set the build number to 0 (for new packages, or if the version changed).
  • Bumped the build number (if the version is unchanged).

@yetalit
Copy link
Copy Markdown
Collaborator

yetalit commented Jul 8, 2025

Hi @Hammad-hab , there are a couple of issues I can observe:

  1. You haven't pinned your MAX version.
  2. Your test file is not included.
  3. The test_parser.mojo file in the main repo doesn't have a main function; So, I think running it will not have any effect.

@Hammad-hab
Copy link
Copy Markdown
Contributor Author

Hammad-hab commented Jul 8, 2025

Ok, I'll take a look and resolve these issues

Copy link
Copy Markdown
Collaborator

@sstadick sstadick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that you can test this with rattler-build build -c https://conda.modular.com/max -c conda-forge --skip-existing=all -r ./recipe.yaml after installing rattler-build locally.

Comment thread recipes/MojoINI/recipe.yaml Outdated
then:
- mojo test test_parser.mojo
files:
recipe:
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: change recipe to source, and it will use the test files in your source repo. Double check that test_parser.mojo is at the top level. That way you don't have to include test files in this repo.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't catch this on the first look!

@Hammad-hab
Copy link
Copy Markdown
Contributor Author

Hi @yetalit.
I've fixed the tests and pinned the max version. Could you have a look to see if it's ok now?

@yetalit
Copy link
Copy Markdown
Collaborator

yetalit commented Jul 12, 2025

Hi @Hammad-hab , following error occurred:

Error:   × Parsing: failed to parse match spec: unable to parse version spec: ='25.4'
    ╭─[21:7]
 20 │   host:
 21 │     - max='25.4'
    ·       ─────┬────
    ·            ╰── error parsing `max='25.4'` as a match spec
 22 │   run:
    ╰────

@Hammad-hab
Copy link
Copy Markdown
Contributor Author

Sorry about that. I fixed the recipe.yaml.

@yetalit yetalit merged commit e05f1d3 into modular:main Jul 12, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants