Skip to content

[BUG] Support workspace scope for lsp.IncludeDirs #20

Description

@josiahls

Actual Behavior

The current and previous extension only passed through the lsp.includeDirs via the User settings.

Image

Note above, 1 project is c_binder_mojo, the other is is mojo project container c_binder_mojo. I need to specify both as I jump between projects.

This means that if someone has 2 different mojo projects, they need to dump the lsp include dir paths to both into a single userwide settings.json instead of the workspace json.

This is made even more difficult by containerized projects have have their own project paths.

Expected behavior

Use includeDirs in .vscode/settings.json that is local per project so that the includeDirs settings are specific to their respective project.

{
    "mojo.lsp.includeDirs": [
        "/home/mojo_user/mujoco_mojo/c_binder_mojo/firehose"
    ],
} 

Possible solution

Are there concerns with changing:

"mojo.lsp.includeDirs": {
  "scope": "machine",

to

"mojo.lsp.includeDirs": {
  "scope": "resource",

in the package.json?

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions