Skip to content

Commit 3254222

Browse files
committed
fix: use model.name (slug) for CMS item name, not display_name
1 parent f6a86ec commit 3254222

2 files changed

Lines changed: 7 additions & 7 deletions

File tree

scripts/fetch-models.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ function normalizeApiModel(model) {
7272

7373
export function buildWebflowFields(model, modalities, categoryMap, logoField) {
7474
return {
75-
name: model.display_name || model.name,
75+
name: model.name,
7676
slug: model.name,
7777
'display-name': model.display_name || '',
7878
'model-id': model.model_id || '',

tests/fetch-models/transform.test.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ describe('buildWebflowFields', () => {
2525

2626
const result = buildWebflowFields(model, modalities, categoryMap, logoField);
2727

28-
assert.equal(result.name, 'My Model');
28+
assert.equal(result.name, 'my-model');
2929
assert.equal(result.slug, 'my-model');
3030
assert.equal(result['display-name'], 'My Model');
3131
assert.equal(result['model-id'], 'org/my-model');
@@ -64,18 +64,18 @@ describe('buildWebflowFields', () => {
6464
assert.deepEqual(result.modalities, []);
6565
});
6666

67-
it('falls back to name when display_name is falsy', () => {
67+
it('uses model.name as the CMS item name (not display_name)', () => {
6868
const model = {
69-
display_name: '',
70-
name: 'fallback-model',
69+
display_name: 'Human Readable Name',
70+
name: 'machine-name',
7171
isLive: false,
7272
isNew: false,
7373
isTrending: false,
7474
};
7575
const result = buildWebflowFields(model, [], {}, null);
7676

77-
assert.equal(result.name, 'fallback-model');
78-
assert.equal(result['display-name'], '');
77+
assert.equal(result.name, 'machine-name');
78+
assert.equal(result['display-name'], 'Human Readable Name');
7979
});
8080

8181
it('drops unknown modalities not in categoryMap', () => {

0 commit comments

Comments
 (0)