Skip to content

Commit 5a9db8e

Browse files
committed
Fix data attributes with dash
1 parent fb8c87c commit 5a9db8e

3 files changed

Lines changed: 9 additions & 7 deletions

File tree

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "modujs",
3-
"version": "1.1.4",
3+
"version": "1.1.5",
44
"description": "Dead simple modular JavaScript framework for ES modules.",
55
"repository": "modularorg/modularjs",
66
"author": "Antoine Boulanger <hello@antoineboulanger.com> (https://antoineboulanger.com)",

src/main.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,8 @@ export default class {
2323

2424
if (i.name.startsWith('data-module')) {
2525
let moduleExists = false;
26-
let moduleName = this.toCamel(i.name.split('-').splice(2));
26+
let dataName = i.name.split('-').splice(2);
27+
let moduleName = this.toCamel(dataName);
2728

2829
if (this.modules[moduleName]) {
2930
moduleExists = true;
@@ -35,7 +36,8 @@ export default class {
3536
if (moduleExists) {
3637
const options = {
3738
el: el,
38-
name: moduleName
39+
name: moduleName,
40+
dataName: dataName.join('-')
3941
};
4042

4143
const module = new this.modules[moduleName](options);
@@ -80,9 +82,9 @@ export default class {
8082

8183
addActiveModule(name, id, module) {
8284
if (this.activeModules[name]) {
83-
Object.assign(this.activeModules[name], { [id]: module });
85+
Object.assign(this.activeModules[name], { [id]: module });
8486
} else {
85-
this.activeModules[name] = { [id]: module };
87+
this.activeModules[name] = { [id]: module };
8688
}
8789
}
8890

src/module.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
export default class {
22
constructor(options) {
3-
this.mAttr = 'data-' + options.name;
3+
this.mAttr = 'data-' + options.dataName;
44
this.el = options.el;
55
}
66

@@ -64,7 +64,7 @@ export default class {
6464
const classIndex = query.indexOf('.');
6565
const idIndex = query.indexOf('#');
6666
const attrIndex = query.indexOf('[');
67-
const indexes = [classIndex, idIndex, attrIndex].filter(index => index != -1);
67+
const indexes = [classIndex, idIndex, attrIndex].filter(index => index != -1);
6868

6969
let index = false;
7070
let name = query;

0 commit comments

Comments
 (0)