fix(bridge-react): restore complete type generation for bridge components#4174
Closed
ScriptedAlchemy wants to merge 1 commit into
Closed
fix(bridge-react): restore complete type generation for bridge components#4174ScriptedAlchemy wants to merge 1 commit into
ScriptedAlchemy wants to merge 1 commit into
Conversation
…ents - Add missing type exports (RenderFnParams, RemoteComponentParams, etc.) to v18.ts and v19.ts - Add new BridgeComponent<T> interface with rawComponent and __BRIDGE_FN__ properties - Update bridge-base.tsx to properly expose rawComponent and __BRIDGE_FN__ - Enhance main index.ts exports for backward compatibility - Improve vite.config.ts DTS plugin configuration for better type bundling - Add comprehensive type tests to verify generated types Fixes #4159
|
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Stale pull request message |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for Issue #4159: bridge-react (0.21.1): Created types are not correct
Problem
The TypeScript types generated for
@module-federation/bridge-reactv0.21.1 were incomplete compared to v0.8.10, missing crucial properties likerawComponent,__BRIDGE_FN__, and proper component props inference.Root Cause
Solution
RenderFnParams,RemoteComponentParams, etc.) to all entry pointsBridgeComponent<T>interface with all required propertiesChanges Made
src/v18.ts&src/v19.ts: Added missing type exportssrc/types.ts: AddedBridgeComponent<T>interfacesrc/provider/versions/bridge-base.tsx: Enhanced return type withrawComponentand__BRIDGE_FN__src/index.ts: Updated main exports for backward compatibilityvite.config.ts: Improved DTS plugin configurationsrc/__tests__/types.test.ts: Added type verification testsExpected Results
After these changes, generated types will include:
render,destroy,rawComponent, and__BRIDGE_FN__WidgetProps)/v18and/v19importsTesting
Fixes #4159