-
-
Notifications
You must be signed in to change notification settings - Fork 411
feat: tsup build alignment and local setup fixes #4460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
e22f492
dce6b4d
76c2216
adff9b6
707aab5
aa47578
14d1b76
04ba1b4
7b274f1
e3de5a3
e0c0704
f953e6e
4c257d8
92b7ec0
2e41604
49d79a6
0ffd5be
043f533
b0ab6dc
385f226
0211f52
ac23c9a
c911bb6
ce7453a
f2ba7eb
ca9fea3
bc4c4e4
cf22aee
abd5278
9c1cdd5
bff9eac
a09448c
1fc42c0
458521c
ab67fba
b36f745
e740098
7ff2d3b
2c05660
4ecd198
b51ed7f
e96f436
fb98314
9e628a9
5f2fd64
d1cbc7d
aa78e0a
93c57bf
e067037
0789d43
ef7c273
e3d9e05
7da3a00
5d4776d
385f646
2c39c19
fc9dc9e
f4fec2a
00f5752
fa2e4de
5cf4ae8
64e51bf
d8962b5
b4706a2
63b5c25
3b2c826
265c2ca
0ff81ec
44def73
14ba6a6
0a9e9bb
cfb7e7b
4ec5bcd
e7a8632
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| '@module-federation/error-codes': patch | ||
| '@module-federation/runtime': patch | ||
| --- | ||
|
|
||
| Migrate `@module-federation/error-codes` and `@module-federation/runtime` package builds from Nx Rollup executor to `tsdown`, and modernize their emitted `dist` filenames and export map targets. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| --- | ||
| '@module-federation/cli': patch | ||
| '@module-federation/managers': patch | ||
| '@module-federation/manifest': patch | ||
| '@module-federation/modern-js': patch | ||
| '@module-federation/modern-js-v3': patch | ||
| '@module-federation/native-federation-tests': patch | ||
| '@module-federation/native-federation-typescript': patch | ||
| '@module-federation/nextjs-mf': patch | ||
| '@module-federation/retry-plugin': patch | ||
| --- | ||
|
|
||
| Add missing release coverage for packages moved to the new build implementation and standardized ESM/CJS artifact outputs. This ensures package versioning and publish automation include the remaining affected packages on this branch. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| --- | ||
| '@module-federation/webpack-bundler-runtime': patch | ||
| '@module-federation/runtime-core': patch | ||
| '@module-federation/utilities': patch | ||
| '@module-federation/node': patch | ||
| '@module-federation/sdk': patch | ||
| '@module-federation/runtime-tools': patch | ||
| '@module-federation/data-prefetch': patch | ||
| '@module-federation/enhanced': patch | ||
| '@module-federation/rspack': patch | ||
| '@module-federation/inject-external-runtime-core-plugin': patch | ||
| --- | ||
|
|
||
| Add runtime-safe access helpers for webpack require, webpack share-scope globals, and ignored dynamic imports, and migrate core/node runtime loaders to use these helpers. The helpers are exposed via a standalone `@module-federation/sdk/bundler` entrypoint so they can be built and consumed independently from the SDK main index bundle. | ||
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -61,7 +61,23 @@ export class PrefetchPlugin implements WebpackPluginInstance { | |
| this.options.runtimePlugins = []; | ||
| } | ||
|
|
||
| const runtimePath = path.resolve(__dirname, './plugin.esm.js'); | ||
| const runtimePluginCandidates = | ||
| process.env.IS_ESM_BUILD === 'true' | ||
| ? ['../plugin.js', '../plugin.cjs'] | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why do we have to do this id we have esm and cjs already why cant paths just be corerct? isnt this both cjs and esm build output? |
||
| : ['../plugin.cjs', '../plugin.js']; | ||
| const runtimePath = runtimePluginCandidates | ||
| .map((candidate) => path.resolve(__dirname, candidate)) | ||
| .find((candidatePath) => fs.existsSync(candidatePath)); | ||
| if (!runtimePath) { | ||
| throw new Error( | ||
| [ | ||
| '[Module Federation Data Prefetch]: Unable to resolve runtime plugin file.', | ||
| `Checked paths: ${runtimePluginCandidates | ||
| .map((candidate) => path.resolve(__dirname, candidate)) | ||
| .join(', ')}`, | ||
| ].join('\n'), | ||
| ); | ||
| } | ||
| if (!this.options.runtimePlugins?.includes(runtimePath)) { | ||
| this.options.runtimePlugins!.push(runtimePath); | ||
| } | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.