Skip to content

test(nextjs-mf): extract pages-router fixtures#4530

Closed
ScriptedAlchemy wants to merge 8 commits into
codex/nextjs-mf-v9-corefrom
codex/nextjs-mf-v9-pages-router
Closed

test(nextjs-mf): extract pages-router fixtures#4530
ScriptedAlchemy wants to merge 8 commits into
codex/nextjs-mf-v9-corefrom
codex/nextjs-mf-v9-pages-router

Conversation

@ScriptedAlchemy

@ScriptedAlchemy ScriptedAlchemy commented Mar 12, 2026

Copy link
Copy Markdown
Member

Summary

Extract the pages-router fixture migration and E2E harness updates on top of the v9 core lane.

Included

  • 3000-home, 3001-shop, and 3002-checkout fixture updates
  • pages-router E2E harness changes
  • fixture lockfile sync required by this slice

Validation

  • pnpm run ci:local --only=e2e-next-prod passed locally on the restacked pages-router branch
  • expected GitHub validation for this layer remains the e2e-next-dev and e2e-next-prod jobs

PR Stack

This PR is 3/4 in the stack.

Stack order (base -> tip):

  1. #4529 feat(runtime): extract webpack compat substrate (base)
  2. #4528 feat(nextjs-mf): extract v9 core rewrite
  3. #4530 test(nextjs-mf): extract pages-router fixtures (current)
  4. #4425 test(nextjs-mf): extract app-router fixtures (tip)

Navigation:

  • Prev: #4528
  • Next: #4425
  • Stack refs: #4529 -> #4528 -> #4530 -> #4425
  • Branch: codex/nextjs-mf-v9-pages-router into codex/nextjs-mf-v9-core

@changeset-bot

changeset-bot Bot commented Mar 12, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 4398c3e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Mar 12, 2026

Copy link
Copy Markdown

Open in StackBlitz

@module-federation/devtools

pnpm add https://pkg.pr.new/@module-federation/devtools@7f2024a

@module-federation/cli

pnpm add https://pkg.pr.new/@module-federation/cli@7f2024a

create-module-federation

pnpm add https://pkg.pr.new/create-module-federation@7f2024a

@module-federation/data-prefetch

pnpm add https://pkg.pr.new/@module-federation/data-prefetch@7f2024a

@module-federation/dts-plugin

pnpm add https://pkg.pr.new/@module-federation/dts-plugin@7f2024a

@module-federation/enhanced

pnpm add https://pkg.pr.new/@module-federation/enhanced@7f2024a

@module-federation/error-codes

pnpm add https://pkg.pr.new/@module-federation/error-codes@7f2024a

@module-federation/esbuild

pnpm add https://pkg.pr.new/@module-federation/esbuild@7f2024a

@module-federation/managers

pnpm add https://pkg.pr.new/@module-federation/managers@7f2024a

@module-federation/manifest

pnpm add https://pkg.pr.new/@module-federation/manifest@7f2024a

@module-federation/metro

pnpm add https://pkg.pr.new/@module-federation/metro@7f2024a

@module-federation/metro-plugin-rnc-cli

pnpm add https://pkg.pr.new/@module-federation/metro-plugin-rnc-cli@7f2024a

@module-federation/metro-plugin-rnef

pnpm add https://pkg.pr.new/@module-federation/metro-plugin-rnef@7f2024a

@module-federation/modern-js

pnpm add https://pkg.pr.new/@module-federation/modern-js@7f2024a

@module-federation/modern-js-v3

pnpm add https://pkg.pr.new/@module-federation/modern-js-v3@7f2024a

@module-federation/native-federation-tests

pnpm add https://pkg.pr.new/@module-federation/native-federation-tests@7f2024a

@module-federation/native-federation-typescript

pnpm add https://pkg.pr.new/@module-federation/native-federation-typescript@7f2024a

@module-federation/nextjs-mf

pnpm add https://pkg.pr.new/@module-federation/nextjs-mf@7f2024a

@module-federation/node

pnpm add https://pkg.pr.new/@module-federation/node@7f2024a

@module-federation/retry-plugin

pnpm add https://pkg.pr.new/@module-federation/retry-plugin@7f2024a

@module-federation/rsbuild-plugin

pnpm add https://pkg.pr.new/@module-federation/rsbuild-plugin@7f2024a

@module-federation/rspack

pnpm add https://pkg.pr.new/@module-federation/rspack@7f2024a

@module-federation/rspress-plugin

pnpm add https://pkg.pr.new/@module-federation/rspress-plugin@7f2024a

@module-federation/runtime

pnpm add https://pkg.pr.new/@module-federation/runtime@7f2024a

@module-federation/runtime-core

pnpm add https://pkg.pr.new/@module-federation/runtime-core@7f2024a

@module-federation/runtime-tools

pnpm add https://pkg.pr.new/@module-federation/runtime-tools@7f2024a

@module-federation/sdk

pnpm add https://pkg.pr.new/@module-federation/sdk@7f2024a

@module-federation/storybook-addon

pnpm add https://pkg.pr.new/@module-federation/storybook-addon@7f2024a

@module-federation/third-party-dts-extractor

pnpm add https://pkg.pr.new/@module-federation/third-party-dts-extractor@7f2024a

@module-federation/treeshake-frontend

pnpm add https://pkg.pr.new/@module-federation/treeshake-frontend@7f2024a

@module-federation/treeshake-server

pnpm add https://pkg.pr.new/@module-federation/treeshake-server@7f2024a

@module-federation/typescript

pnpm add https://pkg.pr.new/@module-federation/typescript@7f2024a

@module-federation/utilities

pnpm add https://pkg.pr.new/@module-federation/utilities@7f2024a

@module-federation/webpack-bundler-runtime

pnpm add https://pkg.pr.new/@module-federation/webpack-bundler-runtime@7f2024a

@module-federation/bridge-react

pnpm add https://pkg.pr.new/@module-federation/bridge-react@7f2024a

@module-federation/bridge-react-webpack-plugin

pnpm add https://pkg.pr.new/@module-federation/bridge-react-webpack-plugin@7f2024a

@module-federation/bridge-shared

pnpm add https://pkg.pr.new/@module-federation/bridge-shared@7f2024a

@module-federation/bridge-vue3

pnpm add https://pkg.pr.new/@module-federation/bridge-vue3@7f2024a

@module-federation/inject-external-runtime-core-plugin

pnpm add https://pkg.pr.new/@module-federation/inject-external-runtime-core-plugin@7f2024a

commit: 7f2024a

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3b86cb5b05

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +11 to +14
React.useEffect(() => {
let isMounted = true;

import('checkout/pages/checkout/index').then((mod) => {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Forward getInitialProps in checkout page proxy

Loading checkout/pages/checkout/index only inside useEffect makes this route client-only for the federated page, so Next.js cannot run the remote page's getInitialProps during SSR. The previous implementation explicitly forwarded Page.getInitialProps, but this proxy never does, which drops the data-loading contract defined in apps/3002-checkout/pages/checkout/index.tsx and can leave /checkout with fallback/empty props on first render.

Useful? React with 👍 / 👎.

Comment on lines +10 to +13
React.useEffect(() => {
let isMounted = true;

import('shop/pages/shop/index').then((mod) => {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Forward getInitialProps in shop page proxy

This proxy also fetches the remote page only after mount, but it no longer forwards the remote static data loader, so Shop.getInitialProps from apps/3001-shop/pages/shop/index.tsx is never executed by Next.js when serving /shop from the checkout app. That is a behavioral regression from the prior re-export pattern and removes SSR data hydration for this federated route.

Useful? React with 👍 / 👎.

@ScriptedAlchemy

Copy link
Copy Markdown
Member Author

Closing per request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant