fix(enhanced): resolve package names in runtimePlugins - #4954
Open
dmchoi77 wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 5bf7f8f The changes in this PR will be included in the next version bump. This PR includes changesets to release 47 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 81f3dc6af3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
dmchoi77
force-pushed
the
fix/runtime-plugin-package-resolution
branch
from
August 3, 2026 16:47
81f3dc6 to
e045621
Compare
dmchoi77
force-pushed
the
fix/runtime-plugin-package-resolution
branch
from
August 3, 2026 16:54
e045621 to
5bf7f8f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
runtimePluginsentries provided as package names were incorrectly converted into paths relative toprocess.cwd(). This caused Webpack to fail before loading the runtime plugin.This PR resolves non-absolute
runtimePluginsentries with Node.js module resolution usingrequire.resolve(entry, { paths: [cwd] }). Existing absolute-path behavior is preserved, and unresolved relative paths continue to fall back to the previouscwd-based path behavior.The change also adds a regression test for scoped package-name resolution and a patch changeset for
@module-federation/enhanced.Related Issue
Fixes #4953
Types of changes
Checklist