comprehensive-demo-react18: inline bootstrap + async startup#4406
comprehensive-demo-react18: inline bootstrap + async startup#4406ScriptedAlchemy wants to merge 6 commits intomasterfrom
Conversation
… (webpack/rspack)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| experiments: { | ||
| css: true, | ||
| mfAsyncStartup: true, | ||
| }, |
Check failure
Code scanning / CodeQL
Overwritten property Error
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 6 months ago
To fix this problem, combine the contents of both experiments properties into a single definition, ensuring that no desired fields are lost. Only one experiments property should remain. The fix should be performed in comprehensive-demo-react18/app-02/rspack.config.js, specifically from lines 21–24 and 64–66. Merge the properties so that experiments contains both css: true and mfAsyncStartup: true. Remove the duplicate second definition (experiments at lines 64–66), and ensure only one experiments block remains in the exported configuration object.
No imports or additional definitions are required.
| @@ -61,9 +61,7 @@ | ||
| }, | ||
| ], | ||
| }, | ||
| experiments: { | ||
| css: true, | ||
| }, | ||
| // Removed duplicate 'experiments' property. See line 21 for the correct, merged definition. | ||
|
|
||
| plugins: [ | ||
| new ModuleFederationPlugin({ |
… for canary version 1.6.2-canary-4e6be088-20251110224718
ScriptedAlchemy
force-pushed
the
feat/async-startup-comprehensive-demo
branch
from
2dffd40 to
962a7ec
Compare
…ackages to canary versions
…rver/plugin packages
…package names (@rspack-canary/core, etc.)
|
Closing: asyncStartup is already enabled on master via #4412. The remaining bootstrap inlining (removing |
2 participants
Remove dynamic entry imports, inline bootstrap in index, enable async startup across webpack (experiments.asyncStartup) and Rspack (experiments.mfAsyncStartup).