fix(loadable-react): use enhanced webpack entrypoint#4420
Merged
Conversation
ScriptedAlchemy
force-pushed
the
chore/deps-canary-pr-4483
branch
from
9fcd967 to
f5568ec
Compare
ScriptedAlchemy
changed the title
|
|
ScriptedAlchemy
force-pushed
the
chore/deps-canary-pr-4483
branch
from
f5568ec to
856e8b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ModuleFederationPluginimports inloadable-react-16andloadable-react-18to@module-federation/enhanced/webpackpkg.pr.newcanary dependency churn from this PR scopeWhy
The previous version of this PR validated unreleased
module-federation/corecanary packages. Those canary pins are no longer useful to carry in the examples repo. The one durable fix is that these webpack examples should use the webpack-specific enhanced plugin entrypoint so enhanced-only options are accepted consistently.Test plan
pnpm --filter loadable-react-16_app1 build:clientpnpm --filter loadable-react-16_app2 build:clientpnpm --filter loadable-react-18_app1 build:clientpnpm --filter loadable-react-18_app2 build:clientgit diff --check