Open
Conversation
There was a problem hiding this comment.
Pull request overview
Renames the Module Federation runtime package to @module-federation/tauri, updates documentation to a usage-first format, and adds MIT license metadata for the JS package and Rust crate.
Changes:
- Renamed runtime package references from
@crabnebula-dev/tauri-module-federationto@module-federation/tauriacross examples and messaging. - Updated root and package READMEs to document the Tauri + Module Federation offline caching flow.
- Added MIT license metadata to the published artifacts (npm package + Rust crate).
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tauri-plugin/src/lib.rs | Updates debug warning string to reference the new runtime package name. |
| tauri-plugin/Cargo.toml | Adds license = "MIT" to crate metadata. |
| README.md | Rewrites root docs to focus on usage/configuration and clarifies behavior/build checks. |
| pnpm-lock.yaml | Updates workspace dependency name and refreshes lockfile entries. |
| module-federation-plugin/README.md | Updates package name and expands usage/behavior docs. |
| module-federation-plugin/package.json | Renames npm package to @module-federation/tauri and adds MIT license metadata. |
| example/host/rsbuild.config.ts | Updates runtimePlugins entry to the new package name. |
| example/host/package.json | Renames dependency to @module-federation/tauri. |
| example/guest/package.json | Renames dependency to @module-federation/tauri. |
| example/guest-2/package.json | Renames dependency to @module-federation/tauri. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zackarychapple
approved these changes
Apr 13, 2026
jbroma
reviewed
Apr 13, 2026
Member
jbroma
left a comment
There was a problem hiding this comment.
Looks good, but without testing the release e2e we can't be really sure of anything here 😅 Perhaps we can split this into rename PR + some manual release orchestration? Honestly, I have no experience with publishing tauri plugins, where we have rust part + js part.
billwatson017
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@module-federation/tauriValidation
pnpm installpnpm --filter example_guest buildpnpm --filter 'example-guest_2' buildpnpm --filter example-host exec rsbuild buildpnpm build:packagepnpm changeset statusYAML.load_file