Commit a0480e2
committed
hotfix(snippets): strip double backticks around getTableName() result (#293)
$modx->getTableName() already returns the table name escaped with
backticks (e.g. `modx_ms3_product_files`). PR #282 wrapped it in
another pair of backticks in the SQL template — runtime SQL had
triple backticks and any `includeThumbs` call from msProducts /
msCart / msGetOrder errored out with:
Error 42000: You have an error in your SQL syntax ... near
'`` `main` WHERE ...'
Catalog listings using `includeThumbs` returned empty results in
1.11.0-beta1 — see issue #293. Removed the outer backticks around %4$s
in the sprintf template; added a comment so future readers don't add
them back.
Caught early — few downloads of 1.11.0-beta1 yet. Re-tagging the
existing version instead of bumping to 1.11.1-beta1.1 parent 7915dde commit a0480e2
1 file changed
Lines changed: 5 additions & 1 deletion
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
31 | 35 | | |
32 | 36 | | |
33 | 37 | | |
34 | 38 | | |
35 | 39 | | |
36 | 40 | | |
37 | 41 | | |
38 | | - | |
| 42 | + | |
39 | 43 | | |
40 | 44 | | |
41 | 45 | | |
| |||
0 commit comments