fix(extra-fields): address PR #301 review (repeater config log, DRY)

- Warn in error log when repeater_config JSON is malformed (with field key)
- Use msProductData::class instead of hardcoded string in ProductDataService
- Drop redundant maxRows check in validateRows after normalizeRows enforces limit

Author: Ibochkarev

core/components/minishop3/src/Services/ExtraFields/RepeaterFieldService.php

@@ -11,7 +11,7 @@ class RepeaterFieldService
 
     private modX $modx;
 
-    /** @var array<string, array<string, array>>|null */
+    /** Request-scoped cache of repeater field configs keyed by model class. */
     private ?array $fieldsByClass = null;
 
     public function __construct(modX $modx)
@@ -37,15 +37,22 @@ public function defaultConfig(): array
 
     /**
      * @param mixed $json JSON string or array
+     * @param string|null $fieldKey Extra field key for log context when config JSON is invalid
      */
-    public function parseConfig(mixed $json): array
+    public function parseConfig(mixed $json, ?string $fieldKey = null): array
     {
         $config = $this->defaultConfig();
 
         if (is_string($json) && $json !== '') {
             $decoded = json_decode($json, true);
             if (is_array($decoded)) {
                 $config = array_merge($config, $decoded);
+            } else {
+                $context = $fieldKey !== null && $fieldKey !== '' ? " for field \"{$fieldKey}\"" : '';
+                $this->modx->log(
+                    modX::LOG_LEVEL_WARN,
+                    '[ms3-repeater] malformed repeater_config JSON' . $context . ': ' . json_last_error_msg()
+                );
             }
         } elseif (is_array($json)) {
             $config = array_merge($config, $json);
@@ -161,16 +168,11 @@ public function validateRows(array $rows, array $config): array
     {
         $errors = [];
         $minRows = (int)($config['minRows'] ?? 0);
-        $maxRows = $config['maxRows'] ?? null;
 
         if (count($rows) < $minRows) {
             $errors[] = "Minimum {$minRows} rows required";
         }
 
-        if ($maxRows !== null && count($rows) > (int)$maxRows) {
-            $errors[] = "Maximum {$maxRows} rows allowed";
-        }
-
         foreach ($rows as $index => $row) {
             if (!is_array($row)) {
                 $errors[] = "Row {$index} must be an object";
@@ -245,7 +247,7 @@ public function getRepeaterFieldsForClass(string $modelClass): array
             if ($key === '') {
                 continue;
             }
-            $map[$key] = $this->parseConfig($field->get('repeater_config'));
+            $map[$key] = $this->parseConfig($field->get('repeater_config'), $key);
         }
 
         $this->fieldsByClass[$modelClass] = $map;

core/components/minishop3/src/Services/Product/ProductDataService.php

@@ -48,7 +48,7 @@ protected function getProductRepeaterFields(): array
     {
         if ($this->productRepeaterFields === null) {
             $this->productRepeaterFields = $this->getRepeaterFieldService()->getRepeaterFieldsForClass(
-                'MiniShop3\\Model\\msProductData'
+                msProductData::class
             );
         }