Skip to content

Commit 566a1c8

Browse files
committed
Fix pill fade: iterate all children materials so both halves disappear
1 parent 5ee29b3 commit 566a1c8

2 files changed

Lines changed: 4 additions & 6 deletions

File tree

docs/index.html

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -196,10 +196,9 @@
196196
// Fade out everything after split
197197
if(splitT>1){
198198
const fade=Math.max(0,1-(splitT-1)*1.5);
199-
topHalf.material.opacity=fade*.5;
200-
botHalf.material.opacity=fade*.5;
199+
clickedPill.children.forEach(m=>{if(m.material)m.material.opacity=fade*.5});
201200
sparkMat.opacity=fade*.3;
202-
innerGlow.intensity=innerGlow.intensity*fade;
201+
innerGlow.intensity=Math.max(0,innerGlow.intensity*fade);
203202
if(fade<=0){clickedPill.visible=false;return}
204203
}
205204
requestAnimationFrame(splitAnim);

mofa-website/src/pages/index.astro

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -623,10 +623,9 @@ let cx=0,cy=0;
623623
// Fade out everything after split
624624
if(splitT>1){
625625
const fade=Math.max(0,1-(splitT-1)*1.5);
626-
topHalf.material.opacity=fade*.5;
627-
botHalf.material.opacity=fade*.5;
626+
clickedPill.children.forEach(m=>{if(m.material)m.material.opacity=fade*.5});
628627
sparkMat.opacity=fade*.3;
629-
innerGlow.intensity=innerGlow.intensity*fade;
628+
innerGlow.intensity=Math.max(0,innerGlow.intensity*fade);
630629
if(fade<=0){clickedPill.visible=false;return}
631630
}
632631
requestAnimationFrame(splitAnim);

0 commit comments

Comments
 (0)