[Multi_K8s-Plugin] Extract images from initContainers and CronJob templates#39
Closed
mohammedfirdouss wants to merge 1 commit into
Closed
[Multi_K8s-Plugin] Extract images from initContainers and CronJob templates#39mohammedfirdouss wants to merge 1 commit into
mohammedfirdouss wants to merge 1 commit into
Conversation
…CronJob templates Signed-off-by: Mohammed Firdous <124298708+mohammedfirdouss@users.noreply.github.com>
Owner
Author
|
Closing — PR opened against wrong repo. Will re-open against pipe-cd/pipecd. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Extends
FindContainerImagesto also extract images frominitContainersand from CronJobjobTemplatepaths. Previously onlyspec.template.spec.containers[*].imagewas checked, so init container images and all CronJob images were silently ignored.Why we need it:
Applications using init containers or CronJobs would have their images missing from version tracking and drift detection.
Which issue(s) this PR fixes:
Fixes pipe-cd#6446
Does this PR introduce a user-facing change?: