Skip to content

Better guard against duplicate results loading. #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfellows merged 1 commit into from
May 5, 2025
Merged

Better guard against duplicate results loading. #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 11 additions & 13 deletions Source/moja.modules.cbm/src/cbmaggregatorhybridlibpqxxwriter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,38 +61,36 @@ namespace cbm {
}

MOJA_LOG_INFO << (boost::format("Loading results into %1% on server: %2%")
% _schema % _pgConnectionString).str();
% _schema % _chConnectionString).str();

connection pgConn(_pgConnectionString);
connection chConn(_chConnectionString);
doIsolated(pgConn, (boost::format("SET search_path = %1%;") % _schema).str());

bool resultsPreviouslyLoaded = perform([&pgConn, this] {
return !nontransaction(pgConn).exec((boost::format(
"SELECT 1 FROM CompletedJobs WHERE id = %1%;"
) % _jobId).str()).empty();
std::string guardTable = (boost::format("completed_%1%") % _jobId).str();
bool resultsPreviouslyLoaded = perform([&chConn, &guardTable, this] {
return nontransaction(chConn).exec((boost::format(
"EXISTS TABLE %1%.%2%;"
) % _schema % guardTable).str()).at(0, 0).as<int>() == 1;
});

if (resultsPreviouslyLoaded) {
MOJA_LOG_INFO << "Results previously loaded for jobId " << _jobId << " - skipping.";
return;
}

perform([&pgConn, &chConn, this] {
work pgTx(pgConn);
perform([&chConn, &guardTable, this] {
work chTx(chConn);

// First, try to insert into the completed jobs table - if this is a duplicate, the transaction
// will fail immediately.
pgTx.exec((boost::format("INSERT INTO CompletedJobs VALUES (%1%);") % _jobId).str());
// ClickHouse doesn't support unique constraints, so the guard against
// duplicate loads for the same job has to be a table. If this is a
// duplicate, the transaction will fail and roll back the data load.
chTx.exec((boost::format("CREATE TABLE %1%.%2% (x INTEGER) ENGINE = MergeTree() ORDER BY x;") % _schema % guardTable).str());

load(chTx, (boost::format("%1%.raw_fluxes") % _schema).str(), _fluxDimension);
load(chTx, (boost::format("%1%.raw_pools") % _schema).str(), _poolDimension);
load(chTx, (boost::format("%1%.raw_errors") % _schema).str(), _errorDimension);
load(chTx, (boost::format("%1%.raw_ages") % _schema).str(), _ageDimension);
load(chTx, (boost::format("%1%.raw_disturbances") % _schema).str(), _disturbanceDimension);

pgTx.commit();
chTx.commit();
});

Expand Down