Switch to Makie 0.24#147
Open
timholy wants to merge 1 commit into
Open
Conversation
The most recent release of the Makie family was a major breaking change, introducing the new `ComputeGraph` architecture and eliminating `MakieCore` as a separate package. This commit updates MolecularGraph to be compatible with Makie 0.24, which includes: - Creating a new extension package `MakieExt` to hold the code that previously leveraged `MakieCore` - Updating the drawing recipes for the new API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The most recent release of the Makie family was a major breaking change, introducing the new
ComputeGrapharchitecture and eliminatingMakieCoreas a separate package. This commit updates MolecularGraph to be compatible with Makie 0.24, which includes:MakieExtto hold the code that previously leveragedMakieCoreNote: I expect the tests to fail due to the name collision described in #146. I have verified locally that this passes tests if merged onto that branch.