fix Makefile to run#2
Open
JeonJuseong wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I looked at your github readme and tried to run the "make contract-tools" command, but it failed.
I saw that there was a slight problem with the makefile.
So I fixed it, and check that it worked fine when I ran it.
As you can see from the changes, I fixed the different method that go-bindata uses to install,
I fixed the use of gencodec@latest without @,
and I fixed the snap install solc part to install with sudo as it kept failing because it didn't have sudo.
A pull request would be appreciated. Thank you.