fix: Allow to set false for actions without mixins#1355
Open
Embraser01 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This allows to easily have "conditional" actions defined in your service (cf. exemple).
The alternative is to wrap it with an object spread or have a "false" mixin handler.
🎯 Relevant issues
I didn't find any issue about that, but I can create one if you prefer.
💎 Type of change
📜 Example code
🚦 How Has This Been Tested?
We got the issue on our side and found the
mergeSchemaActionsmethod that handles it. I then found a test case toadd this use case to see if I could repro it.
Once reproduced in unit tests, I fixed it in the code.
🏁 Checklist: