Work on issue #104 re: error form

Is probably resolved now
Now hitting Enter when in the error form
    and using the "Refresh with current errors" right-click context item
    do the same thing, as they always should have done.

Author: molsonkiko

CHANGELOG.md

@@ -63,6 +63,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 2. Minor bug where JsonTools could not set the text of a file to end with the SOH character (ASCII code `\x01`)
 3. Minor bug where some JsonGrepper tests would always fail because they queried an external API that had previously returned JSON but now returns HTML.
 4. Bug where editing a document in [multi-selection mode](/docs/README.md#working-with-selections) would sometimes cause selections to be forgotten (fixed in [v8.4.0.3](https://github.com/molsonkiko/JsonToolsNppPlugin/commit/16f0358274c662273a2015994c5ab22d22fd23ab))
+5. Bug ([issue 104](https://github.com/molsonkiko/JsonToolsNppPlugin/issues/104)) where [error form](/docs/README.md#error-form-and-status-bar) would not always re-parse the document after the `Refresh with current errors` right-click context menu item on the error form was clicked.
 
 ## [8.4.0] - 2025-05-04
 

JsonToolsNppPlugin/Forms/ErrorForm.cs

@@ -166,10 +166,39 @@ private void ErrorForm_RightClick(object sender, MouseEventArgs e)
             }
         }
 
+        /// <summary>
+        /// does the following:<br></br>
+        /// 1. temporarily suppress prompt asking if error form should be shown<br></br>
+        /// 2. if automatic schema validation is desired, re-validate<br></br>
+        /// 3. Re-parse the JSON<br></br>
+        /// 4. Re-display the error form with all the lints found in steps 2 and 3 
+        /// </summary>
+        private void RefreshWithContentsOfCurrentFile()
+        {
+            Main.errorFormTriggeredParse = true;
+            // temporarily turn off offer_to_show_lint prompt, because the user obviously wants to see it
+            bool previousOfferToShowLint = Main.settings.offer_to_show_lint;
+            Main.settings.offer_to_show_lint = false;
+            Main.TryParseJson(preferPreviousDocumentType: true);
+            if (Main.TryGetInfoForFile(Main.activeFname, out JsonFileInfo info)
+                && info.lints != null)
+            {
+                if (info.filenameOfMostRecentValidatingSchema is null)
+                    Reload(Main.activeFname, info.lints);
+                else
+                {
+                    Main.ValidateJson(info.filenameOfMostRecentValidatingSchema, false);
+                    if (Main.TryGetInfoForFile(Main.activeFname, out info) && info.lints != null && info.statusBarSection != null && info.statusBarSection.Contains("fatal errors"))
+                        Reload(Main.activeFname, info.lints);
+                }
+            }
+            Main.settings.offer_to_show_lint = previousOfferToShowLint;
+            Main.errorFormTriggeredParse = false;
+        }
+
         private void RefreshMenuItem_Click(object sender, EventArgs e)
         {
-            Npp.notepad.HideDockingForm(this);
-            Main.OpenErrorForm(Npp.notepad.GetCurrentFilePath(), false);
+            RefreshWithContentsOfCurrentFile();
         }
 
         private void ExportLintsToJsonMenuItem_Click(object sender, EventArgs e)
@@ -203,27 +232,8 @@ private void ErrorForm_KeyUp(object sender, KeyEventArgs e)
         {
             if (e.KeyCode == Keys.Enter)
             {
-                // refresh error form based on current contents of current file
                 e.Handled = true;
-                Main.errorFormTriggeredParse = true;
-                // temporarily turn off offer_to_show_lint prompt, because the user obviously wants to see it
-                bool previousOfferToShowLint = Main.settings.offer_to_show_lint;
-                Main.settings.offer_to_show_lint = false;
-                Main.TryParseJson(preferPreviousDocumentType:true);
-                if (Main.TryGetInfoForFile(Main.activeFname, out JsonFileInfo info)
-                    && info.lints != null)
-                {
-                    if (info.filenameOfMostRecentValidatingSchema is null)
-                        Reload(Main.activeFname, info.lints);
-                    else
-                    {
-                        Main.ValidateJson(info.filenameOfMostRecentValidatingSchema, false);
-                        if (Main.TryGetInfoForFile(Main.activeFname, out info) && info.lints != null && info.statusBarSection != null && info.statusBarSection.Contains("fatal errors"))
-                            Reload(Main.activeFname, info.lints);
-                    }
-                }
-                Main.settings.offer_to_show_lint = previousOfferToShowLint;
-                Main.errorFormTriggeredParse = false;
+                RefreshWithContentsOfCurrentFile();
                 return;
             }
             else if (e.KeyCode == Keys.Escape)

JsonToolsNppPlugin/Properties/AssemblyInfo.cs

@@ -28,5 +28,5 @@
 //      Build Number
 //      Revision
 //
-[assembly: AssemblyVersion("8.4.0.3")]
-[assembly: AssemblyFileVersion("8.4.0.3")]
+[assembly: AssemblyVersion("8.4.0.4")]
+[assembly: AssemblyFileVersion("8.4.0.4")]

docs/README.md

@@ -194,11 +194,11 @@ As the above example shows, this method *can* handle unmatched quotes/braces, bu
 
 ### Error form and status bar ###
 
-If you click "Yes", a docking form will open up at the bottom of the document. Each row in the document will correspond to a different syntax error.
+If you respond "Yes" to the prompt that appears after parsing JSON with errors, a docking form will open up at the bottom of the document. Each row in the document will correspond to a different syntax error.
 
 Clicking on or paging to a row in the error form with the arrow keys will move the caret to the location in the document where that error was found.
 
-Hitting `Enter` while in the form refreshes the form with the JSON in the current document. You can also seek the next syntax error with a description that starts with a letter by typing that letter while in the form. For example, typing `P` in the form might select the next `Python-style '#' comments are not part of any well-accepted JSON specification` error.
+Hitting `Enter` or choosing the `Refresh with current errors` right-click context menu item while in the form refreshes the form with the JSON in the current document. You can also seek the next syntax error with a description that starts with a letter by typing that letter while in the form. For example, typing `P` in the form might select the next `Python-style '#' comments are not part of any well-accepted JSON specification` error.
 
 Beginning in [v6.0](/CHANGELOG.md#600---2023-12-13), you can right-click on this form to gain the option of exporting all errors to JSON or refreshing the form.