Release v8.4.0.4

- update GitHub references to point to this branch
- Add indicators showing that this is the big integer version,
    not the main version,
    since they will be maintained in parallel
- fix bug where integers bigger than double.MaxValue
    would be treated as bigger than double.Infinity

Author: molsonkiko

CHANGELOG.md

@@ -1,5 +1,5 @@
 # Change Log
-All [notable changes](#840---2025-05-04) to this project will be documented in this file.
+All [notable changes](#8404---2025-07-24) to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
@@ -36,6 +36,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ### To Be Fixed
 
+- Crash bugs described in issues [46](https://github.com/molsonkiko/JsonToolsNppPlugin/issues/46) and [59](https://github.com/molsonkiko/JsonToolsNppPlugin/issues/59).
+	- I don't think these issues are caused by the plugins config directory having a path length greater than `Win32.MAX_PATH`, because the error messages that people are seeing look different from the error message that I get when I deliberately create that issue.
+	- I also doubt that the issue is due to a race condition where the delayed-parse-after-editing thread tries to access `jsonFileInfos` when it's being deleted, because such an error would not appear at startup, and it would only appear sometimes on shutdown, not all the time.
 - Make sure there aren't any easily-triggered race conditions induced by [automatic parsing and validation after editing](/docs/README.md#automatically-check-for-errors-after-editing).
     - In 6.1.1.18, there is no longer a global shared JsonParser, which was the main potential source of race conditions.
 - Fix issue where pretty-printing or compressing causes tree view position tracking to be out of sync with the document until a query is issued or the `Refresh` button is hit.
@@ -48,7 +51,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 - Since v7.0, holding down `Enter` in a multiline textbox (like the [tree viewer query box](/docs/README.md#remespath)) only adds one newline when the key is lifted.
 - Maybe use pre-7.1 (dictionary-based rather than indicator-based) [selection remembering](/docs/README.md#working-with-selections) for Notepad++ 8.5.5 and earlier? Indicators are risky with those older NPP's because of the lack of `NPPM_ALLOCATEINDICATOR`.
 
-## [9.0.0] - (UNRELEASED) YYYY-MM-DD
+## [8.4.0.4] - 2025-07-24
 
 ### Changed
 
@@ -60,7 +63,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 1. Add [`recurse_until` RemesPath function](/docs/RemesPath.md#non-vectorized-functions) to recursively search arrays and objects for anything inside that satisfies a condition.
 2. Add [`keyboard_shortcuts` setting](/docs/README.md#the-basics), allowing users to turn off default JsonTools keyboard shortcuts.
-3. Courtesy of user [hydy100](https://github.com/hydy100), [Translation](https://github.com/molsonkiko/JsonToolsNppPlugin/blob/main/translation) to Arabic, Chinese (simplified), French, German, Japanese, Korean, and Taiwanese Mandarin.
+3. Courtesy of user [hydy100](https://github.com/hydy100), [Translation](https://github.com/molsonkiko/JsonToolsNppPlugin/blob/big_integer_for_Dtype_INT/translation) to Arabic, Chinese (simplified), French, German, Japanese, Korean, and Taiwanese Mandarin.
 
 ### Fixed
 

JsonToolsNppPlugin/Forms/AboutForm.Designer.cs

@@ -117,6 +117,12 @@
   <resheader name="writer">
     <value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
   </resheader>
+  <data name="Description.Text" xml:space="preserve">
+    <value>Query/editing tool for JSON including linting, reformatting, 
+a tree viewer with file navigation,
+a JMESpath-like query language, and much more.
+This version of JsonTools supports arbitrarily large integers.</value>
+  </data>
   <data name="ThanksWowLinkLabel.Text" xml:space="preserve">
     <value>Special thanks to:
 * Don Ho for making Notepad++

JsonToolsNppPlugin/Forms/AboutForm.resx

@@ -98,7 +98,7 @@ Stringify iterables
 
         private void DocsButton_Click(object sender, EventArgs e)
         {
-            Main.OpenUrlInWebBrowser("https://github.com/molsonkiko/JSONToolsNppPlugin/tree/main/docs/json-to-csv.md");
+            Main.OpenUrlInWebBrowser("https://github.com/molsonkiko/JSONToolsNppPlugin/tree/big_integer_for_Dtype_INT/docs/json-to-csv.md");
         }
     }
 }

JsonToolsNppPlugin/Forms/JsonToCsvForm.cs

@@ -812,6 +812,8 @@ public int CompareTo(object other)
                         return bi.CompareTo(obi);
                     if (other is double od)
                     {
+                        if (double.IsInfinity(od))
+                            return od < 0 ? 1 : -1;
                         if (bi > DoubleMaxValueAsBigInt)
                             return 1;
                         if (bi < DoubleMinValueAsBigInt)
@@ -822,9 +824,13 @@ public int CompareTo(object other)
                         return bi.CompareTo(b ? BigInteger.One : BigInteger.Zero);
                     throw new ArgumentException("Can't compare numbers to non-numbers");
                 case Dtype.FLOAT:
-                    if (!(other is BigInteger || other is double || other is bool))
+                    bool otherIsDouble = other is double;
+                    if (!(otherIsDouble || other is BigInteger || other is bool))
                         throw new ArgumentException("Can't compare numbers to non-numbers");
-                    return ((double)value).CompareTo(ConvertJNodeValueToDouble(other));
+                    var d = (double)value;
+                    if (!otherIsDouble && double.IsInfinity(d))
+                        return d < 0 ? -1 : 1; // need to address possibility that other is integer outside the range of doubles
+                    return d.CompareTo(ConvertJNodeValueToDouble(other));
                 case Dtype.BOOL:
                     if (!(other is BigInteger || other is double || other is bool))
                         throw new ArgumentException("Can't compare numbers to non-numbers");

JsonToolsNppPlugin/JSONTools/JNode.cs

@@ -24,7 +24,7 @@ class Main
         #region " Fields "
         internal const int UNDO_BUFFER_SIZE = 64;
         internal const string PluginName = "JsonTools";
-        public const string PluginRepoUrl = "https://github.com/molsonkiko/JsonToolsNppPlugin";
+        public const string PluginRepoUrl = "https://github.com/molsonkiko/JsonToolsNppPlugin/tree/big_integer_for_Dtype_INT";
         // general stuff things
         public static Settings settings = new Settings();
         public static IniFileParser iniParser = new IniFileParser();
@@ -450,8 +450,13 @@ static internal void FileRenameCancel(IntPtr bufferRenamedId)
             shouldRenameGrepperForm = false;
         }
 
+        /// <summary>
+        /// called once when Notepad++ is shutting down normally (in response to <see cref="NppMsg.NPPN_SHUTDOWN"/>
+        /// </summary>
         static internal void PluginCleanUp()
         {
+            // turn off auto-validation because we're about to remove jsonFileInfos
+            settings.auto_validate = false;
             if (grepperForm != null && !grepperForm.IsDisposed)
             {
                 grepperForm.Close();

JsonToolsNppPlugin/Main.cs

@@ -28,5 +28,5 @@
 //      Build Number
 //      Revision
 //
-[assembly: AssemblyVersion("8.4.0.3")]
-[assembly: AssemblyFileVersion("8.4.0.3")]
+[assembly: AssemblyVersion("8.4.0.4")]
+[assembly: AssemblyFileVersion("8.4.0.4")]

JsonToolsNppPlugin/Properties/AssemblyInfo.cs

@@ -34,6 +34,7 @@ public static bool Test()
             JsonParser jsonParser = new JsonParser();
             RemesParser remesparser = new RemesParser();
             Npp.AddLine($"The queried JSON in the RemesParser tests is named foo:{fooStr}");
+            string hugeIntegerStr = ArgFunction.StrMulHelper("10", 160);
             var testcases = new Query_DesiredResult[]
             {
                 // subtraction
@@ -164,6 +165,10 @@ public static bool Test()
                 new Query_DesiredResult("17 == 16.6", "false"),
                 new Query_DesiredResult("16.6 < 17", "true"),
                 new Query_DesiredResult("16.6 == 17", "false"),
+                new Query_DesiredResult($"{hugeIntegerStr} < Infinity", "true"), // integer bigger than largest double is less than Infinity
+                new Query_DesiredResult($"Infinity > {hugeIntegerStr}", "true"), // integer bigger than largest double is less than Infinity
+                new Query_DesiredResult($"-{hugeIntegerStr} > -Infinity", "true"), // integer lower than largest negative double is greater than -Infinity
+                new Query_DesiredResult($"-Infinity < -{hugeIntegerStr}", "true"), // integer lower than largest negative double is greater than -Infinity
                 // uminus tests
                 new Query_DesiredResult("-j`[1]`", "[-1]"),
                 new Query_DesiredResult("-j`[1,2]`**-3", "[-1.0, -0.125]"), // check uminus comes after exponentiation