Skip to content

Commit 7c47aab

Browse files
anitaruamalandis
andauthored
ci: remove testing python 3.7 and 3.8, add testing python 3.12 (#498)
* ci: remove testing python 3.7 and 3.8, add testing python 3.12 and 3.13 * remove 3.13 for now * test examples against 3.12 too * try examples with 3.12 allowed * revise python version in examples again to allow 3.12 * chore: use newer grpcio for python 3.13 Because grpcio 1.66.2 is the minimum version that supports python 3.13, we add a conditional dependency on that version. * ci: run ci for python v3.13 * revert: momento-wire-types shouldn't be in test deps Previously I mistakenly cut and paste this to the test deps section. * chore: add note about minimum grpcio version --------- Co-authored-by: Michael Landis <michael@momentohq.com>
1 parent a0a1382 commit 7c47aab

4 files changed

Lines changed: 78 additions & 19 deletions

File tree

.github/workflows/on-pull-request.yml

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -10,22 +10,8 @@ jobs:
1010
matrix:
1111
# TODO: one of the examples dependencies does not support 3.11
1212
os: [ubuntu-24.04]
13-
python-version: ["3.9", "3.10", "3.11"]
13+
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
1414
new-python-protobuf: ["true"]
15-
include:
16-
# 3.7 and 3.8 are no longer available on ubuntu-24.04
17-
# We run on 20.04 which was the last version where this worked.
18-
# If support for 20.04 becomes an issue, we can install 3.7 and 3.8
19-
# with pyenv or manually.
20-
- python-version: "3.7"
21-
new-python-protobuf: "true"
22-
os: ubuntu-20.04
23-
- python-version: "3.7"
24-
new-python-protobuf: "false"
25-
os: ubuntu-20.04
26-
- python-version: "3.8"
27-
new-python-protobuf: "true"
28-
os: ubuntu-20.04
2915
runs-on: ${{ matrix.os }}
3016

3117
env:
@@ -85,6 +71,8 @@ jobs:
8571
package: py310
8672
- python-version: "3.11"
8773
package: py310
74+
- python-version: "3.12"
75+
package: py310
8876
# For simplicity, the examples use a cache called "test-cache"
8977
# Therefore we cannot run them in parallel or else we could prematurely delete
9078
# the cache for one job in another job.

examples/pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ authors = ["Momento <hello@momentohq.com>"]
66
license = "Apache-2.0"
77

88
[tool.poetry.dependencies]
9-
python = ">=3.7,<3.12"
9+
python = ">=3.7,<3.13"
1010

1111
momento = "1.26.0"
1212
colorlog = "6.7.0"

poetry.lock

Lines changed: 69 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pyproject.toml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,11 @@ exclude = ["src/momento/internal/codegen.py"]
3131
python = "^3.7"
3232

3333
momento-wire-types = "^0.119.4"
34-
grpcio = "^1.46.0"
34+
grpcio = [
35+
{ version = "^1.46.0", python = "<3.13" },
36+
# v1.66.2 is the minimum grpcio version that supports python 3.13
37+
{ version = "^1.66.2", python = ">=3.13" },
38+
]
3539
# note if you bump this presigned url test need be updated
3640
pyjwt = "^2.4.0"
3741

0 commit comments

Comments
 (0)