chore: add tests for the fixed count retry strategy#503
Merged
Conversation
anitarua
reviewed
Apr 11, 2025
pgautier404
reviewed
Apr 15, 2025
nand4011
force-pushed
the
retry-tests
branch
2 times, most recently
from
11d42a8 to
1302613
Compare
Add sync and async tests for the fixed count retry strategy. Add a make target for local tests. Add a github action to run the local tests. Fix a linter error.
malandis
reviewed
May 1, 2025
| .PHONY: test-local | ||
| ## Run the integration tests that require Momento Local | ||
| test-local: | ||
| @poetry run pytest -m local |
Contributor
There was a problem hiding this comment.
🎗️ this only runs the momento-local specific tests. In the future we could run the entire test suite against Momento local.
Contributor
Author
There was a problem hiding this comment.
Part of my dilemma when choosing a name for this was that we'll have tests like these that always run against momento local, and the standard integration tests that could run with it. I wasn't sure whether we should separate those. We can solve that problem in the future, I suppose.
Comment on lines
+62
to
+64
| markers = [ | ||
| "local: tests that require Momento Local", | ||
| ] |
|
|
||
|
|
||
| class MomentoRpcMethod(Enum): | ||
| GET = ("_GetRequest", "get") |
Contributor
There was a problem hiding this comment.
Interesting. I didn't know the enum values could be tuples.
|
|
||
|
|
||
| class TestFixedCountRetryStrategyAsync: | ||
| @pytest.mark.local |
malandis
approved these changes
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a middleware that lets tests control Momento Local with metadata and can collect metrics about retries.
Add sync and async tests for the fixed count retry strategy.
Update the aio retry interceptor to stop if from ignoring the result of a future in some cases.
Add a make target for local tests.
Add a github action to run the local tests.