chore: send only-once headers per client instead of just once#507
Merged
chore: send only-once headers per client instead of just once#507
Conversation
Send the only-once headers once per instance of the add header interceptor, instead of once over the life of the program. The old behavior would make a cache client stop a topics client from sending the agent header, and vice versa.
malandis
approved these changes
May 1, 2025
Comment on lines
-19
to
-20
| are_only_once_headers_sent = False | ||
|
|
Contributor
There was a problem hiding this comment.
Good find. These were class variables like this. If this were a data class, they would be instance variables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Send the only-once headers once per instance of the add header interceptor, instead of once over the life of the program. The old behavior would make a cache client stop a topics client from sending the agent header, and vice versa.