fix balance accounting of payable functions

Author: pdobacz

src/ethereum/forks/monad_eight/vm/precompiled_contracts/staking.py

@@ -15,7 +15,6 @@
 
 from ethereum_types.numeric import U256, Uint
 
-from ...state import get_account, set_account_balance
 from ...vm import Evm
 from ...vm.exceptions import InvalidParameter, RevertInMonadPrecompile
 from ...vm.gas import charge_gas
@@ -397,13 +396,3 @@ def staking(evm: Evm) -> None:
             raise RevertInMonadPrecompile
     else:
         raise InvalidParameter
-
-    # FIXME: is that so?
-    # Payable calls consume value (staking system absorbs it)
-    if is_payable and evm.message.value != U256(0):
-        state = evm.message.block_env.state
-        precompile = evm.message.current_target
-        account = get_account(state, precompile)
-        set_account_balance(
-            state, precompile, account.balance - evm.message.value
-        )

src/ethereum/forks/monad_nine/vm/precompiled_contracts/staking.py

@@ -15,7 +15,6 @@
 
 from ethereum_types.numeric import U256, Uint
 
-from ...state import get_account, set_account_balance
 from ...vm import Evm
 from ...vm.exceptions import InvalidParameter, RevertInMonadPrecompile
 from ...vm.gas import charge_gas
@@ -397,13 +396,3 @@ def staking(evm: Evm) -> None:
             raise RevertInMonadPrecompile
     else:
         raise InvalidParameter
-
-    # FIXME: is that so?
-    # Payable calls consume value (staking system absorbs it)
-    if is_payable and evm.message.value != U256(0):
-        state = evm.message.block_env.state
-        precompile = evm.message.current_target
-        account = get_account(state, precompile)
-        set_account_balance(
-            state, precompile, account.balance - evm.message.value
-        )

tests/monad_eight/staking_precompile/test_precompile_call.py

@@ -1035,14 +1035,11 @@ def test_tx_revert_scenarios(
     )
 
     if scenario.should_succeed(func):
-        post: dict = {sender: Account(balance=0)}
-        # FIXME: which is correct? does the precompile hide the balance?
         # Value was transferred to precompile
-        # post = {
-        #     sender: Account(balance=0),
-        #     STAKING_PRECOMPILE:
-        # Account(balance=value) if value > 0 else None,
-        # }
+        post = {
+            sender: Account(balance=0),
+            STAKING_PRECOMPILE: Account(balance=value) if value > 0 else None,
+        }
     else:
         post = {sender: Account(balance=value)}