test: add tests for karma pattern, per-user rate limits, and team roles

Author: PenguinDevs

tests/conftest.py

@@ -4,7 +4,7 @@
 from sqlmodel.ext.asyncio.session import AsyncSession
 
 from src.backend.db import Database
-from src.backend.models import GuildConfig, KarmaTransaction, KarmaWindow, User  # noqa: F401 — register tables
+from src.backend.models import GuildConfig, KarmaTransaction, KarmaWindow, User, UserTeamRole  # noqa: F401 — register tables
 from src.backend.tables import KarmaTransactionDB, KarmaWindowDB, UserDB
 
 

tests/test_karma_pattern.py

@@ -0,0 +1,62 @@
+"""Tests for the karma regex pattern matching."""
+
+from src.cogs.commands.karma import KARMA_PATTERN
+
+
+def test_matches_user_plus():
+    matches = KARMA_PATTERN.findall("<@123456> +++")
+    assert len(matches) == 1
+    assert matches[0] == ("123456", "+++")
+
+
+def test_matches_user_minus():
+    matches = KARMA_PATTERN.findall("<@123456> ---")
+    assert len(matches) == 1
+    assert matches[0] == ("123456", "---")
+
+
+def test_matches_role_plus():
+    matches = KARMA_PATTERN.findall("<@&999> +++++")
+    assert len(matches) == 1
+    assert matches[0] == ("999", "+++++")
+
+
+def test_matches_role_minus():
+    matches = KARMA_PATTERN.findall("<@&999> -----")
+    assert len(matches) == 1
+    assert matches[0] == ("999", "-----")
+
+
+def test_matches_nickname_format():
+    matches = KARMA_PATTERN.findall("<@!123456> ++")
+    assert len(matches) == 1
+    assert matches[0] == ("123456", "++")
+
+
+def test_no_match_single_plus():
+    matches = KARMA_PATTERN.findall("<@123456> +")
+    assert len(matches) == 0
+
+
+def test_no_match_single_minus():
+    matches = KARMA_PATTERN.findall("<@123456> -")
+    assert len(matches) == 0
+
+
+def test_multiple_mentions():
+    matches = KARMA_PATTERN.findall("<@111> ++ <@222> +++")
+    assert len(matches) == 2
+    assert matches[0] == ("111", "++")
+    assert matches[1] == ("222", "+++")
+
+
+def test_mixed_plus_minus():
+    matches = KARMA_PATTERN.findall("<@111> +++ <@222> ---")
+    assert len(matches) == 2
+    assert matches[0] == ("111", "+++")
+    assert matches[1] == ("222", "---")
+
+
+def test_no_match_plain_text():
+    matches = KARMA_PATTERN.findall("hello world")
+    assert len(matches) == 0

tests/test_karma_rate_limits.py

@@ -0,0 +1,79 @@
+"""Tests for per-user karma rate limit queries."""
+
+from datetime import datetime, timedelta, timezone
+
+from src.backend.models import User
+from src.backend.tables import KarmaTransactionDB, UserDB
+
+
+async def _seed_users(user_db: UserDB):
+    await user_db.upsert(User(user_id=1))
+    await user_db.upsert(User(user_id=2))
+    await user_db.upsert(User(user_id=3))
+
+
+async def test_karma_given_to_user_since(
+    karma_transaction_db: KarmaTransactionDB, user_db: UserDB
+):
+    await _seed_users(user_db)
+    await karma_transaction_db.log(recipient_id=2, performed_by=1, amount=3)
+    await karma_transaction_db.log(recipient_id=2, performed_by=1, amount=2)
+    await karma_transaction_db.log(recipient_id=3, performed_by=1, amount=10)
+
+    since = datetime.now(timezone.utc) - timedelta(hours=1)
+    total = await karma_transaction_db.karma_given_to_user_since(1, 2, since)
+    assert total == 5
+
+
+async def test_karma_given_to_user_since_zero(
+    karma_transaction_db: KarmaTransactionDB,
+):
+    since = datetime.now(timezone.utc) - timedelta(hours=1)
+    total = await karma_transaction_db.karma_given_to_user_since(1, 2, since)
+    assert total == 0
+
+
+async def test_oldest_transaction_to_user(
+    karma_transaction_db: KarmaTransactionDB, user_db: UserDB
+):
+    await _seed_users(user_db)
+    await karma_transaction_db.log(recipient_id=2, performed_by=1, amount=3)
+    await karma_transaction_db.log(recipient_id=2, performed_by=1, amount=2)
+
+    since = datetime.now(timezone.utc) - timedelta(hours=1)
+    oldest = await karma_transaction_db.oldest_transaction_to_user_since(1, 2, since)
+    assert oldest is not None
+
+
+async def test_oldest_transaction_to_user_none(
+    karma_transaction_db: KarmaTransactionDB,
+):
+    since = datetime.now(timezone.utc) - timedelta(hours=1)
+    oldest = await karma_transaction_db.oldest_transaction_to_user_since(1, 999, since)
+    assert oldest is None
+
+
+async def test_negative_karma_tracked(
+    karma_transaction_db: KarmaTransactionDB, user_db: UserDB
+):
+    """Negative karma transactions reduce the total given."""
+    await _seed_users(user_db)
+    await karma_transaction_db.log(recipient_id=2, performed_by=1, amount=3)
+    await karma_transaction_db.log(recipient_id=2, performed_by=1, amount=-2)
+
+    since = datetime.now(timezone.utc) - timedelta(hours=1)
+    total = await karma_transaction_db.karma_given_to_user_since(1, 2, since)
+    assert total == 1
+
+
+async def test_negative_karma_global(
+    karma_transaction_db: KarmaTransactionDB, user_db: UserDB
+):
+    """Global sum accounts for negative transactions."""
+    await _seed_users(user_db)
+    await karma_transaction_db.log(recipient_id=2, performed_by=1, amount=5)
+    await karma_transaction_db.log(recipient_id=3, performed_by=1, amount=-3)
+
+    since = datetime.now(timezone.utc) - timedelta(hours=1)
+    total = await karma_transaction_db.karma_given_since(1, since)
+    assert total == 2

tests/test_user_team_role_db.py

@@ -0,0 +1,100 @@
+"""Tests for UserTeamRoleDB."""
+
+from datetime import datetime, timezone
+
+from src.backend.models import KarmaWindow, User
+from src.backend.tables.db_user_team_role import UserTeamRoleDB
+from src.backend.tables import UserDB, KarmaWindowDB
+
+
+FIXED_WINDOW = datetime(2026, 1, 1, tzinfo=timezone.utc)
+
+
+async def test_sync_member_roles(test_db):
+    db = UserTeamRoleDB(db=test_db)
+    await db.sync_member_roles(guild_id=1, user_id=100, current_team_role_ids=[10, 20])
+
+    r1 = await db.get(1, 100, 10)
+    r2 = await db.get(1, 100, 20)
+    assert r1 is not None
+    assert r2 is not None
+
+
+async def test_sync_replaces_old_roles(test_db):
+    db = UserTeamRoleDB(db=test_db)
+    await db.sync_member_roles(guild_id=1, user_id=100, current_team_role_ids=[10, 20])
+    await db.sync_member_roles(guild_id=1, user_id=100, current_team_role_ids=[30])
+
+    assert await db.get(1, 100, 10) is None
+    assert await db.get(1, 100, 20) is None
+    assert await db.get(1, 100, 30) is not None
+
+
+async def test_sync_empty_clears_all(test_db):
+    db = UserTeamRoleDB(db=test_db)
+    await db.sync_member_roles(guild_id=1, user_id=100, current_team_role_ids=[10])
+    await db.sync_member_roles(guild_id=1, user_id=100, current_team_role_ids=[])
+
+    assert await db.get(1, 100, 10) is None
+
+
+async def test_get_team_karma(test_db):
+    user_db = UserDB(db=test_db)
+    team_db = UserTeamRoleDB(db=test_db)
+    window_db = KarmaWindowDB(db=test_db)
+
+    # Create users and windows
+    await user_db.upsert(User(user_id=100))
+    await user_db.upsert(User(user_id=200))
+    await window_db.upsert(KarmaWindow(user_id=100, karma=10, karma_start_dt=FIXED_WINDOW))
+    await window_db.upsert(KarmaWindow(user_id=200, karma=20, karma_start_dt=FIXED_WINDOW))
+
+    # Assign team roles
+    await team_db.sync_member_roles(guild_id=1, user_id=100, current_team_role_ids=[50])
+    await team_db.sync_member_roles(guild_id=1, user_id=200, current_team_role_ids=[50])
+
+    results = await team_db.get_team_karma(guild_id=1, window_start=FIXED_WINDOW)
+    assert len(results) == 1
+    role_id, total = results[0]
+    assert role_id == 50
+    assert total == 30
+
+
+async def test_get_team_karma_multiple_teams(test_db):
+    user_db = UserDB(db=test_db)
+    team_db = UserTeamRoleDB(db=test_db)
+    window_db = KarmaWindowDB(db=test_db)
+
+    await user_db.upsert(User(user_id=100))
+    await window_db.upsert(KarmaWindow(user_id=100, karma=10, karma_start_dt=FIXED_WINDOW))
+
+    # User in two teams — their karma counts for both
+    await team_db.sync_member_roles(guild_id=1, user_id=100, current_team_role_ids=[50, 60])
+
+    results = await team_db.get_team_karma(guild_id=1, window_start=FIXED_WINDOW)
+    assert len(results) == 2
+    totals = {role_id: total for role_id, total in results}
+    assert totals[50] == 10
+    assert totals[60] == 10
+
+
+async def test_get_team_karma_empty(test_db):
+    team_db = UserTeamRoleDB(db=test_db)
+    results = await team_db.get_team_karma(guild_id=1, window_start=FIXED_WINDOW)
+    assert results == []
+
+
+async def test_get_team_karma_scoped_by_guild(test_db):
+    user_db = UserDB(db=test_db)
+    team_db = UserTeamRoleDB(db=test_db)
+    window_db = KarmaWindowDB(db=test_db)
+
+    await user_db.upsert(User(user_id=100))
+    await window_db.upsert(KarmaWindow(user_id=100, karma=10, karma_start_dt=FIXED_WINDOW))
+
+    # Assign to team in guild 1 only
+    await team_db.sync_member_roles(guild_id=1, user_id=100, current_team_role_ids=[50])
+
+    # Query guild 2 should return nothing
+    results = await team_db.get_team_karma(guild_id=2, window_start=FIXED_WINDOW)
+    assert results == []