Enhancements

mondeja · mondeja · commit 5bdc475ecef5 · 2022-02-27T21:20:36.000+01:00
- Add `__version__` to `__init__.py`
- Allow to import the package with `from pre_commit_po_hooks import __version__`
- More descriptive names for CLI namespace
diff --git a/.bumpversion.cfg b/.bumpversion.cfg
@@ -1,6 +1,8 @@
 [bumpversion]
-current_version = 1.7.0
+current_version = 1.7.3
 
 [bumpversion:file:setup.cfg]
 
 [bumpversion:file:README.md]
+
+[bumpversion:file:pre_commit_po_hooks/__init__.py]
diff --git a/.pre-commit-hooks.yaml b/.pre-commit-hooks.yaml
@@ -30,43 +30,43 @@
   language: python
 - id: check-metadata
   name: check-metadata
-  entry: check-metadata-hook
+  entry: check-po-metadata-hook
   description: Checks that the metadata values of your PO files matchs against some regexes
   files: \.po$
   language: python
 - id: standard-metadata
   name: standard-metadata
-  entry: check-metadata-hook --standard-headers
+  entry: check-po-metadata-hook --standard-headers
   description: Checks that the metadata of your PO files fits a set of standard requirements
   files: \.po$
   language: python
 - id: no-metadata
   name: no-metadata
-  entry: check-metadata-hook --no-metadata
+  entry: check-po-metadata-hook --no-metadata
   description: Checks that your PO files don't contain metadata headers
   files: \.po$
   language: python
 - id: remove-metadata
   name: remove-metadata
-  entry: check-metadata-hook --no-metadata --remove-metadata
+  entry: check-po-metadata-hook --no-metadata --remove-metadata
   description: Removes metadata headers from your PO files
   files: \.po$
   language: python
 - id: check-entries
   name: check-entries
-  entry: check-entries-hook
+  entry: check-po-entries-hook
   description: Check that PO files entries match a set of requirements passed by parameters
   files: \.po$
   language: python
 - id: max-messages
   name: max-messages
-  entry: check-entries-hook --max-messages
+  entry: check-po-entries-hook --max-messages
   description: Checks that each one of your PO files don't contain more than X messages
   files: \.po$
   language: python
 - id: max-lines
   name: max-lines
-  entry: check-entries-hook --max-lines
+  entry: check-po-entries-hook --max-lines
   description: Checks that each one of your PO files don't contain more than X lines
   files: \.po$
   language: python
diff --git a/README.md b/README.md
@@ -11,7 +11,7 @@ Hooks for pre-commit useful working with PO files.
 
 ```yaml
 - repo: https://github.com/mondeja/pre-commit-po-hooks
-  rev: v1.7.0
+  rev: v1.7.3
   hooks:
     - id: obsolete-messages
     - id: untranslated-messages
diff --git a/hooks/__init__.py b/hooks/__init__.py
diff --git a/pre_commit_po_hooks/__init__.py b/pre_commit_po_hooks/__init__.py
@@ -0,0 +1 @@
+__version__ = "1.7.3"
diff --git a/pre_commit_po_hooks/check_entries.py b/pre_commit_po_hooks/check_entries.py
diff --git a/pre_commit_po_hooks/check_metadata.py b/pre_commit_po_hooks/check_metadata.py
diff --git a/pre_commit_po_hooks/fuzzy_messages.py b/pre_commit_po_hooks/fuzzy_messages.py
diff --git a/pre_commit_po_hooks/lreplace_extracted_comments.py b/pre_commit_po_hooks/lreplace_extracted_comments.py
diff --git a/pre_commit_po_hooks/obsolete_messages.py b/pre_commit_po_hooks/obsolete_messages.py
diff --git a/pre_commit_po_hooks/untranslated_messages.py b/pre_commit_po_hooks/untranslated_messages.py
@@ -31,7 +31,10 @@ def check_untranslated_messages(filenames, min_=None, quiet=False):
         with open(filename) as f:
             content_lines = f.readlines()
 
-        untranslated_messages, total_messages = -1, -1
+        if len(content_lines) > 4:  # skip first empty message
+            content_lines = content_lines[4:]
+
+        untranslated_messages, total_messages = 0, -1
 
         for i, line in enumerate(content_lines):
             next_i = i + 1
diff --git a/setup.cfg b/setup.cfg
@@ -1,6 +1,6 @@
 [metadata]
 name = pre_commit_po_hooks
-version = 1.7.0
+version = 1.7.3
 description = pre-commit hooks for PO files
 long_description = file: README.md
 long_description_content_type = text/markdown
@@ -21,7 +21,7 @@ classifiers =
     Programming Language :: Python :: 3.10
 
 [options]
-packages = find:
+packages = pre_commit_po_hooks
 python_requires = >=3.6.1
 
 [options.packages.find]
@@ -30,12 +30,12 @@ exclude =
 
 [options.entry_points]
 console_scripts =
-    obsolete-messages-hook = hooks.obsolete_messages:main
-    untranslated-messages-hook = hooks.untranslated_messages:main
-    fuzzy-messages-hook = hooks.fuzzy_messages:main
-    lreplace-extracted-comments-hook = hooks.lreplace_extracted_comments:main
-    check-metadata-hook = hooks.check_metadata:main
-    check-entries-hook = hooks.check_entries:main
+    obsolete-messages-hook = pre_commit_po_hooks.obsolete_messages:main
+    untranslated-messages-hook = pre_commit_po_hooks.untranslated_messages:main
+    fuzzy-messages-hook = pre_commit_po_hooks.fuzzy_messages:main
+    lreplace-extracted-comments-hook = pre_commit_po_hooks.lreplace_extracted_comments:main
+    check-po-metadata-hook = pre_commit_po_hooks.check_metadata:main
+    check-po-entries-hook = pre_commit_po_hooks.check_entries:main
 
 [options.extras_require]
 dev =
diff --git a/tests/test_check_entries.py b/tests/test_check_entries.py
@@ -6,7 +6,10 @@
 
 import pytest
 
-from hooks.check_entries import maximum_number_of_lines, maximum_number_of_messages
+from pre_commit_po_hooks.check_entries import (
+    maximum_number_of_lines,
+    maximum_number_of_messages,
+)
 
 
 @pytest.mark.parametrize("quiet", (False, True), ids=("quiet=False", "quiet=True"))
diff --git a/tests/test_check_metadata.py b/tests/test_check_metadata.py
@@ -7,7 +7,7 @@
 
 import pytest
 
-from hooks.check_metadata import check_metadata
+from pre_commit_po_hooks.check_metadata import check_metadata
 
 
 @pytest.mark.parametrize("quiet", (False, True), ids=("quiet=False", "quiet=True"))
diff --git a/tests/test_fuzzy_messages.py b/tests/test_fuzzy_messages.py
@@ -7,7 +7,7 @@
 
 import pytest
 
-from hooks.fuzzy_messages import check_fuzzy_messages
+from pre_commit_po_hooks.fuzzy_messages import check_fuzzy_messages
 
 
 """
diff --git a/tests/test_lreplace_extracted_comments.py b/tests/test_lreplace_extracted_comments.py
@@ -7,7 +7,7 @@
 
 import pytest
 
-from hooks.lreplace_extracted_comments import lreplace_extracted_comments
+from pre_commit_po_hooks.lreplace_extracted_comments import lreplace_extracted_comments
 
 
 @pytest.mark.parametrize("quiet", (False, True), ids=("quiet=False", "quiet=True"))
diff --git a/tests/test_obsolete_messages.py b/tests/test_obsolete_messages.py
@@ -7,7 +7,7 @@
 
 import pytest
 
-from hooks.obsolete_messages import check_obsolete_messages
+from pre_commit_po_hooks.obsolete_messages import check_obsolete_messages
 
 
 @pytest.mark.parametrize("quiet", (False, True), ids=("quiet=False", "quiet=True"))
diff --git a/tests/test_untranslated_messages.py b/tests/test_untranslated_messages.py
@@ -7,7 +7,7 @@
 
 import pytest
 
-from hooks.untranslated_messages import check_untranslated_messages
+from pre_commit_po_hooks.untranslated_messages import check_untranslated_messages
 
 
 @pytest.mark.parametrize("min_", ("100%", None), ids=("min_=100%", "min=None"))
