refactor: deduplicate schemas per PR review

- Replace inline CheckoutCustomerSchema with CustomerSchema.nullable()
- Remove unnecessary OrderDetailSchema alias

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: npslaney

src/contracts/checkout.ts

@@ -1,6 +1,7 @@
 import { oc } from "@orpc/contract";
 import { z } from "zod";
 import { CheckoutSchema } from "../schemas/checkout";
+import { CustomerSchema } from "../schemas/customer";
 import { CurrencySchema } from "../schemas/currency";
 import {
 	PaginationInputSchema,
@@ -168,19 +169,7 @@ export const listCheckoutsContract = oc
 	.output(ListCheckoutsOutputSchema);
 
 // MCP-specific embedded customer schema
-const CheckoutCustomerSchema = z
-	.object({
-		id: z.string(),
-		name: z.string().nullable(),
-		email: z.string().nullable(),
-		emailVerified: z.boolean(),
-		externalId: z.string().nullable(),
-		userMetadata: z.record(z.unknown()).nullable(),
-		organizationId: z.string(),
-		createdAt: z.date(),
-		modifiedAt: z.date().nullable(),
-	})
-	.nullable();
+const CheckoutCustomerSchema = CustomerSchema.nullable();
 
 // MCP-specific summary schema for list (simpler than full CheckoutSchema)
 const CheckoutListItemSchema = z.object({

src/contracts/order.ts

@@ -7,15 +7,12 @@ import {
 	PaginationOutputSchema,
 } from "../schemas/pagination";
 
-// Order with related data for list view
+// Order with related data for list and get views
 const OrderWithRelationsSchema = OrderSchema.extend({
 	customer: CustomerSchema.nullable(),
 	orderItems: z.array(OrderItemSchema),
 });
 
-// Order with full details for get view
-const OrderDetailSchema = OrderWithRelationsSchema;
-
 const ListOrdersInputSchema = PaginationInputSchema.extend({
 	customerId: z.string().optional(),
 	status: z.string().optional(), // Prisma uses String type for status
@@ -31,7 +28,7 @@ export const listOrdersContract = oc
 
 export const getOrderContract = oc
 	.input(z.object({ id: z.string() }))
-	.output(OrderDetailSchema);
+	.output(OrderWithRelationsSchema);
 
 export const order = {
 	list: listOrdersContract,