Set channel reserve to 0 for full withdrawal (#1)

Set both min_their_channel_reserve_satoshis and
their_channel_reserve_proportional_millionths to 0 in channel
handshake config for JIT channels. Both settings are required:

- min_their_channel_reserve_satoshis: minimum absolute reserve
- their_channel_reserve_proportional_millionths: proportional reserve

Updated rust-lightning dependency to version with configurable
minimum channel reserve support.

Author: amackillop

Cargo.toml

@@ -40,16 +40,16 @@ default = []
 # lightning-liquidity = { version = "0.1.0", features = ["std"] }
 
 # Branch: https://github.com/moneydevkit/rust-lightning/commits/lsp-0.1.8_accept-underpaying-htlcs/
-lightning = { git = "https://github.com/moneydevkit/rust-lightning", rev = "42bad4fd3c908958b96b6b70ed63bd6aa3cbaf5f", features = ["std"] }
-lightning-types = { git = "https://github.com/moneydevkit/rust-lightning", rev = "42bad4fd3c908958b96b6b70ed63bd6aa3cbaf5f" }
-lightning-invoice = { git = "https://github.com/moneydevkit/rust-lightning", rev = "42bad4fd3c908958b96b6b70ed63bd6aa3cbaf5f", features = ["std"] }
-lightning-net-tokio = { git = "https://github.com/moneydevkit/rust-lightning", rev = "42bad4fd3c908958b96b6b70ed63bd6aa3cbaf5f" }
-lightning-persister = { git = "https://github.com/moneydevkit/rust-lightning", rev = "42bad4fd3c908958b96b6b70ed63bd6aa3cbaf5f" }
-lightning-background-processor = { git = "https://github.com/moneydevkit/rust-lightning", rev = "42bad4fd3c908958b96b6b70ed63bd6aa3cbaf5f", features = ["futures"] }
-lightning-rapid-gossip-sync = { git = "https://github.com/moneydevkit/rust-lightning", rev = "42bad4fd3c908958b96b6b70ed63bd6aa3cbaf5f" }
-lightning-block-sync = { git = "https://github.com/moneydevkit/rust-lightning", rev = "42bad4fd3c908958b96b6b70ed63bd6aa3cbaf5f", features = ["rpc-client", "tokio"] }
-lightning-transaction-sync = { git = "https://github.com/moneydevkit/rust-lightning", rev = "42bad4fd3c908958b96b6b70ed63bd6aa3cbaf5f", features = ["esplora-async-https", "time", "electrum"] }
-lightning-liquidity = { git = "https://github.com/moneydevkit/rust-lightning", rev = "42bad4fd3c908958b96b6b70ed63bd6aa3cbaf5f", features = ["std"] }
+lightning = { git = "https://github.com/moneydevkit/rust-lightning", rev = "490192370412ee4289940e90281a9c2b504ea310", features = ["std"] }
+lightning-types = { git = "https://github.com/moneydevkit/rust-lightning", rev = "490192370412ee4289940e90281a9c2b504ea310" }
+lightning-invoice = { git = "https://github.com/moneydevkit/rust-lightning", rev = "490192370412ee4289940e90281a9c2b504ea310", features = ["std"] }
+lightning-net-tokio = { git = "https://github.com/moneydevkit/rust-lightning", rev = "490192370412ee4289940e90281a9c2b504ea310" }
+lightning-persister = { git = "https://github.com/moneydevkit/rust-lightning", rev = "490192370412ee4289940e90281a9c2b504ea310" }
+lightning-background-processor = { git = "https://github.com/moneydevkit/rust-lightning", rev = "490192370412ee4289940e90281a9c2b504ea310", features = ["futures"] }
+lightning-rapid-gossip-sync = { git = "https://github.com/moneydevkit/rust-lightning", rev = "490192370412ee4289940e90281a9c2b504ea310" }
+lightning-block-sync = { git = "https://github.com/moneydevkit/rust-lightning", rev = "490192370412ee4289940e90281a9c2b504ea310", features = ["rpc-client", "tokio"] }
+lightning-transaction-sync = { git = "https://github.com/moneydevkit/rust-lightning", rev = "490192370412ee4289940e90281a9c2b504ea310", features = ["esplora-async-https", "time", "electrum"] }
+lightning-liquidity = { git = "https://github.com/moneydevkit/rust-lightning", rev = "490192370412ee4289940e90281a9c2b504ea310", features = ["std"] }
 
 #lightning = { path = "../rust-lightning/lightning", features = ["std"] }
 #lightning-types = { path = "../rust-lightning/lightning-types" }
@@ -100,7 +100,7 @@ winapi = { version = "0.3", features = ["winbase"] }
 [dev-dependencies]
 # lightning = { version = "0.1.0", features = ["std", "_test_utils"] }
 # Branch: https://github.com/moneydevkit/rust-lightning/commits/lsp-0.1.8_accept-underpaying-htlcs/
-lightning = { git = "https://github.com/moneydevkit/rust-lightning", rev = "42bad4fd3c908958b96b6b70ed63bd6aa3cbaf5f", features = ["std", "_test_utils"] }
+lightning = { git = "https://github.com/moneydevkit/rust-lightning", rev = "490192370412ee4289940e90281a9c2b504ea310", features = ["std", "_test_utils"] }
 #lightning = { path = "../rust-lightning/lightning", features = ["std", "_test_utils"] }
 proptest = "1.0.0"
 regex = "1.5.6"

src/liquidity.rs

@@ -795,6 +795,8 @@ where
 				// TODO: revisit this decision eventually.
 				config.channel_config.forwarding_fee_base_msat = 0;
 				config.channel_config.forwarding_fee_proportional_millionths = 0;
+				config.channel_handshake_config.min_their_channel_reserve_satoshis = 0;
+				config.channel_handshake_config.their_channel_reserve_proportional_millionths = 0;
 
 				match self.channel_manager.create_channel(
 					their_network_key,
@@ -1079,6 +1081,8 @@ where
 				// TODO: revisit this decision eventually.
 				config.channel_config.forwarding_fee_base_msat = 0;
 				config.channel_config.forwarding_fee_proportional_millionths = 0;
+				config.channel_handshake_config.min_their_channel_reserve_satoshis = 0;
+				config.channel_handshake_config.their_channel_reserve_proportional_millionths = 0;
 
 				// TODO: does LSPS4 service need to track this? seems like no?
 				let user_channel_id = 0;