test: add is_splice_already_pending tests, bump rust-lightning rev

Update to afe7b5bb0 which includes splice unit tests.

Author: martinsaposnic

Cargo.toml

@@ -42,17 +42,17 @@ default = []
 # lightning-macros = { version = "0.2.0" }
 
 # Branch: https://github.com/moneydevkit/rust-lightning/commits/feature/lsps4-splice-in/
-lightning = { git = "https://github.com/moneydevkit/rust-lightning", rev = "f6c56daa9", features = ["std"] }
-lightning-types = { git = "https://github.com/moneydevkit/rust-lightning", rev = "f6c56daa9" }
-lightning-invoice = { git = "https://github.com/moneydevkit/rust-lightning", rev = "f6c56daa9", features = ["std"] }
-lightning-net-tokio = { git = "https://github.com/moneydevkit/rust-lightning", rev = "f6c56daa9" }
-lightning-persister = { git = "https://github.com/moneydevkit/rust-lightning", rev = "f6c56daa9", features = ["tokio"] }
-lightning-background-processor = { git = "https://github.com/moneydevkit/rust-lightning", rev = "f6c56daa9" }
-lightning-rapid-gossip-sync = { git = "https://github.com/moneydevkit/rust-lightning", rev = "f6c56daa9" }
-lightning-block-sync = { git = "https://github.com/moneydevkit/rust-lightning", rev = "f6c56daa9", features = ["rest-client", "rpc-client", "tokio"] }
-lightning-transaction-sync = { git = "https://github.com/moneydevkit/rust-lightning", rev = "f6c56daa9", features = ["esplora-async-https", "time", "electrum-rustls-ring"] }
-lightning-liquidity = { git = "https://github.com/moneydevkit/rust-lightning", rev = "f6c56daa9", features = ["std"] }
-lightning-macros = { git = "https://github.com/moneydevkit/rust-lightning", rev = "f6c56daa9" }
+lightning = { git = "https://github.com/moneydevkit/rust-lightning", rev = "afe7b5bb0", features = ["std"] }
+lightning-types = { git = "https://github.com/moneydevkit/rust-lightning", rev = "afe7b5bb0" }
+lightning-invoice = { git = "https://github.com/moneydevkit/rust-lightning", rev = "afe7b5bb0", features = ["std"] }
+lightning-net-tokio = { git = "https://github.com/moneydevkit/rust-lightning", rev = "afe7b5bb0" }
+lightning-persister = { git = "https://github.com/moneydevkit/rust-lightning", rev = "afe7b5bb0", features = ["tokio"] }
+lightning-background-processor = { git = "https://github.com/moneydevkit/rust-lightning", rev = "afe7b5bb0" }
+lightning-rapid-gossip-sync = { git = "https://github.com/moneydevkit/rust-lightning", rev = "afe7b5bb0" }
+lightning-block-sync = { git = "https://github.com/moneydevkit/rust-lightning", rev = "afe7b5bb0", features = ["rest-client", "rpc-client", "tokio"] }
+lightning-transaction-sync = { git = "https://github.com/moneydevkit/rust-lightning", rev = "afe7b5bb0", features = ["esplora-async-https", "time", "electrum-rustls-ring"] }
+lightning-liquidity = { git = "https://github.com/moneydevkit/rust-lightning", rev = "afe7b5bb0", features = ["std"] }
+lightning-macros = { git = "https://github.com/moneydevkit/rust-lightning", rev = "afe7b5bb0" }
 
 #lightning = { path = "../rust-lightning/lightning", features = ["std"] }
 #lightning-types = { path = "../rust-lightning/lightning-types" }
@@ -101,7 +101,7 @@ winapi = { version = "0.3", features = ["winbase"] }
 [dev-dependencies]
 # lightning = { version = "0.2.0", features = ["std", "_test_utils"] }
 # Branch: https://github.com/moneydevkit/rust-lightning/commits/lsp-0.2.0/
-lightning = { git = "https://github.com/moneydevkit/rust-lightning", rev = "f6c56daa9", features = ["std", "_test_utils"] }
+lightning = { git = "https://github.com/moneydevkit/rust-lightning", rev = "afe7b5bb0", features = ["std", "_test_utils"] }
 #lightning = { path = "../rust-lightning/lightning", features = ["std", "_test_utils"] }
 proptest = "1.0.0"
 regex = "1.5.6"

src/liquidity.rs

@@ -2315,3 +2315,31 @@ impl LSPS1Liquidity {
 		Ok(response)
 	}
 }
+
+#[cfg(test)]
+mod tests {
+	use super::*;
+
+	#[test]
+	fn test_is_splice_already_pending() {
+		let pending_err = APIError::APIMisuseError {
+			err: "Channel abc cannot be spliced, as it has already a splice pending".to_string(),
+		};
+		assert!(is_splice_already_pending(&pending_err));
+
+		let other_err = APIError::APIMisuseError {
+			err: "Channel abc cannot be spliced as it is either pending open/close".to_string(),
+		};
+		assert!(!is_splice_already_pending(&other_err));
+
+		let zero_err = APIError::APIMisuseError {
+			err: "Channel abc cannot be spliced; contribution cannot be zero".to_string(),
+		};
+		assert!(!is_splice_already_pending(&zero_err));
+
+		let channel_unavailable = APIError::ChannelUnavailable {
+			err: "some error".to_string(),
+		};
+		assert!(!is_splice_already_pending(&channel_unavailable));
+	}
+}