Invoke process_pending_htlcs on HTLC expiry timer

Calls the new LSPS4 process_pending_htlcs() method on the
existing 5-second HTLC expiry timer. This retries forwarding
HTLCs that were deferred at peer_connected time because the
channel was not yet usable (channel_reestablish still in
progress).

Author: amackillop

Cargo.toml

@@ -42,17 +42,17 @@ default = []
 # lightning-macros = { version = "0.2.0" }
 
 # Branch: https://github.com/moneydevkit/rust-lightning/commits/lsp-0.2.0/
-lightning = { git = "https://github.com/moneydevkit/rust-lightning", rev = "1432d063c277f303266a6a5345789617f2e05e85", features = ["std"] }
-lightning-types = { git = "https://github.com/moneydevkit/rust-lightning", rev = "1432d063c277f303266a6a5345789617f2e05e85" }
-lightning-invoice = { git = "https://github.com/moneydevkit/rust-lightning", rev = "1432d063c277f303266a6a5345789617f2e05e85", features = ["std"] }
-lightning-net-tokio = { git = "https://github.com/moneydevkit/rust-lightning", rev = "1432d063c277f303266a6a5345789617f2e05e85" }
-lightning-persister = { git = "https://github.com/moneydevkit/rust-lightning", rev = "1432d063c277f303266a6a5345789617f2e05e85", features = ["tokio"] }
-lightning-background-processor = { git = "https://github.com/moneydevkit/rust-lightning", rev = "1432d063c277f303266a6a5345789617f2e05e85" }
-lightning-rapid-gossip-sync = { git = "https://github.com/moneydevkit/rust-lightning", rev = "1432d063c277f303266a6a5345789617f2e05e85" }
-lightning-block-sync = { git = "https://github.com/moneydevkit/rust-lightning", rev = "1432d063c277f303266a6a5345789617f2e05e85", features = ["rest-client", "rpc-client", "tokio"] }
-lightning-transaction-sync = { git = "https://github.com/moneydevkit/rust-lightning", rev = "1432d063c277f303266a6a5345789617f2e05e85", features = ["esplora-async-https", "time", "electrum-rustls-ring"] }
-lightning-liquidity = { git = "https://github.com/moneydevkit/rust-lightning", rev = "1432d063c277f303266a6a5345789617f2e05e85", features = ["std"] }
-lightning-macros = { git = "https://github.com/moneydevkit/rust-lightning", rev = "1432d063c277f303266a6a5345789617f2e05e85" }
+lightning = { git = "https://github.com/moneydevkit/rust-lightning", rev = "c14b445c941614f0e76d52afd0c84a6bc3078c79", features = ["std"] }
+lightning-types = { git = "https://github.com/moneydevkit/rust-lightning", rev = "c14b445c941614f0e76d52afd0c84a6bc3078c79" }
+lightning-invoice = { git = "https://github.com/moneydevkit/rust-lightning", rev = "c14b445c941614f0e76d52afd0c84a6bc3078c79", features = ["std"] }
+lightning-net-tokio = { git = "https://github.com/moneydevkit/rust-lightning", rev = "c14b445c941614f0e76d52afd0c84a6bc3078c79" }
+lightning-persister = { git = "https://github.com/moneydevkit/rust-lightning", rev = "c14b445c941614f0e76d52afd0c84a6bc3078c79", features = ["tokio"] }
+lightning-background-processor = { git = "https://github.com/moneydevkit/rust-lightning", rev = "c14b445c941614f0e76d52afd0c84a6bc3078c79" }
+lightning-rapid-gossip-sync = { git = "https://github.com/moneydevkit/rust-lightning", rev = "c14b445c941614f0e76d52afd0c84a6bc3078c79" }
+lightning-block-sync = { git = "https://github.com/moneydevkit/rust-lightning", rev = "c14b445c941614f0e76d52afd0c84a6bc3078c79", features = ["rest-client", "rpc-client", "tokio"] }
+lightning-transaction-sync = { git = "https://github.com/moneydevkit/rust-lightning", rev = "c14b445c941614f0e76d52afd0c84a6bc3078c79", features = ["esplora-async-https", "time", "electrum-rustls-ring"] }
+lightning-liquidity = { git = "https://github.com/moneydevkit/rust-lightning", rev = "c14b445c941614f0e76d52afd0c84a6bc3078c79", features = ["std"] }
+lightning-macros = { git = "https://github.com/moneydevkit/rust-lightning", rev = "c14b445c941614f0e76d52afd0c84a6bc3078c79" }
 
 #lightning = { path = "../rust-lightning/lightning", features = ["std"] }
 #lightning-types = { path = "../rust-lightning/lightning-types" }
@@ -101,7 +101,7 @@ winapi = { version = "0.3", features = ["winbase"] }
 [dev-dependencies]
 # lightning = { version = "0.2.0", features = ["std", "_test_utils"] }
 # Branch: https://github.com/moneydevkit/rust-lightning/commits/lsp-0.2.0/
-lightning = { git = "https://github.com/moneydevkit/rust-lightning", rev = "1432d063c277f303266a6a5345789617f2e05e85", features = ["std", "_test_utils"] }
+lightning = { git = "https://github.com/moneydevkit/rust-lightning", rev = "c14b445c941614f0e76d52afd0c84a6bc3078c79", features = ["std", "_test_utils"] }
 #lightning = { path = "../rust-lightning/lightning", features = ["std", "_test_utils"] }
 proptest = "1.0.0"
 regex = "1.5.6"

src/lib.rs

@@ -635,7 +635,8 @@ impl Node {
 							return;
 						}
 						_ = tokio::time::sleep(Duration::from_secs(HTLC_EXPIRY_CHECK_INTERVAL_SECS)) => {
-								liquidity_handler.handle_expired_htlcs().await;
+							liquidity_handler.process_pending_htlcs();
+							liquidity_handler.handle_expired_htlcs().await;
 						}
 						_ = liquidity_handler.handle_next_event() => {}
 					}

src/liquidity.rs

@@ -502,6 +502,12 @@ where
 		}
 	}
 
+	pub(crate) fn process_pending_htlcs(&self) {
+		if let Some(lsps4_service_handler) = self.liquidity_manager.lsps4_service_handler() {
+			lsps4_service_handler.process_pending_htlcs();
+		}
+	}
+
 	pub(crate) async fn handle_next_event(&self) {
 		match self.liquidity_manager.next_event_async().await {
 			LiquidityEvent::LSPS1Client(LSPS1ClientEvent::SupportedOptionsReady {