Expose channel_funding_fee_sats_per_kwu on Node#25
Open
amackillop wants to merge 1 commit intolsp-0.7.0_accept-underpaying-htlcs_with_timing_logsfrom
Open
Expose channel_funding_fee_sats_per_kwu on Node#25amackillop wants to merge 1 commit intolsp-0.7.0_accept-underpaying-htlcs_with_timing_logsfrom
amackillop wants to merge 1 commit intolsp-0.7.0_accept-underpaying-htlcs_with_timing_logsfrom
Conversation
Add a narrow public accessor that returns the current ChannelFunding fee-rate estimate in sat/kwu. The underlying OnchainFeeEstimator and ConfirmationTarget remain pub(crate); this method gives downstream callers (mdkd's auto-splice manager) just the scalar they need to budget on-chain fees for splice transactions without depending on internal types. Returning sat/kwu rather than a FeeRate struct keeps the surface type-stable across bitcoin/rust-lightning bumps and matches the unit ldk-node already uses internally for ChannelFunding. NOTE: Can drop this commit after upgrading fork to 0.8.0
martinsaposnic
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a narrow public accessor that returns the current ChannelFunding fee-rate estimate in sat/kwu. The underlying OnchainFeeEstimator and ConfirmationTarget remain pub(crate); this method gives downstream callers (mdkd's auto-splice manager) just the scalar they need to budget on-chain fees for splice transactions without depending on internal types.
Returning sat/kwu rather than a FeeRate struct keeps the surface type-stable across bitcoin/rust-lightning bumps and matches the unit ldk-node already uses internally for ChannelFunding.
NOTE: Can drop this commit after upgrading fork to 0.8.0