Skip to content

Update ldk-node and bpi #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amackillop merged 2 commits into from
May 27, 2026
Merged

Update ldk-node and bpi #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75263c2
Update ldk-node and bpi
amackillop May 26, 2026
0c3ccd9
Unblock aws-lc-sys cross-compile in CI
amackillop May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,16 @@ jobs:
target: x86_64-unknown-linux-gnu
docker: ghcr.io/napi-rs/napi-rs/nodejs-rust:lts-debian
build: |
set -e
apt-get update
apt-get install -y lld
# The napi-rs image pre-sets TARGET_CC/TARGET_CXX to a custom gcc
# that does not understand `-fuse-ld=lld`, which aws-lc-sys passes
# unconditionally for x86_64. aws-lc-sys reads TARGET_CC ahead of
# CC_<target> and CC, so we unset it so CC=clang (already in the
# image) takes effect; clang supports -fuse-ld=lld with lld
# installed.
unset TARGET_CC TARGET_CXX TARGET_AR
rustup install $RUST_VERSION
rustup default $RUST_VERSION
rustup target add x86_64-unknown-linux-gnu
Expand All @@ -94,7 +104,17 @@ jobs:
build: |
set -e
apt-get update
apt-get install -y gcc-aarch64-linux-gnu libc6-dev-arm64-cross
apt-get install -y gcc-aarch64-linux-gnu libc6-dev-arm64-cross lld
# The napi-rs docker image pre-sets TARGET_CC and CFLAGS pointing
# to its custom cross-toolchain at /usr/aarch64-unknown-linux-gnu,
# whose sysroot lacks stdatomic.h. aws-lc-sys reads TARGET_CC
# ahead of CC_<target>, so unset both and re-export the Debian
# cross-toolchain values below.
unset TARGET_CC TARGET_CXX TARGET_AR
unset CFLAGS
unset CC_aarch64_unknown_linux_gnu
unset CXX_aarch64_unknown_linux_gnu
unset AR_aarch64_unknown_linux_gnu
export CC_aarch64_unknown_linux_gnu=aarch64-linux-gnu-gcc
export CXX_aarch64_unknown_linux_gnu=aarch64-linux-gnu-g++
export AR_aarch64_unknown_linux_gnu=aarch64-linux-gnu-ar
Expand Down
4 changes: 2 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@ tikv-jemallocator = { version = "0.6", features = ["disable_initial_exec_tls"] }
# Branch: https://github.com/moneydevkit/bitcoin-payment-instructions/tree/2025-12-ldk-node-base
# Pinned to the same git rev as ldk-node's transitive pull to avoid duplicate
# crate compilation. Verify with `cargo tree -d | grep bitcoin-payment-instructions`.
bitcoin-payment-instructions = { git = "https://github.com/moneydevkit/bitcoin-payment-instructions", rev = "bc7d03f", default-features = false, features = [
bitcoin-payment-instructions = { git = "https://github.com/moneydevkit/bitcoin-payment-instructions", rev = "bdcef061488bcc619142010a2a69cd49462d8843", default-features = false, features = [
"http",
] }
# Branch: https://github.com/moneydevkit/ldk-node/commits/lsp-0.7.0_accept-underpaying-htlcs_with_timing_logs
ldk-node = { default-features = false, git = "https://github.com/moneydevkit/ldk-node.git", rev = "5616db4ed0db15534d6d92356fef8c5bad79acb1" }
ldk-node = { default-features = false, git = "https://github.com/moneydevkit/ldk-node.git", rev = "f13fcead7e02ef4b77489a83854f204de11e902b" }
#ldk-node = { path = "../ldk-node" }

napi = { version = "2", features = ["napi4"] }
Expand Down
Loading