Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a8f50b543c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
NatElkins
force-pushed
the
mdk-403
branch
2 times, most recently
from
8c2de1a to
e0dc23b
Compare
|
@codex Review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
@codex Review |
|
Codex Review: Didn't find any major issues. Nice work! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
- Add listProducts action and clientListProducts client-side function - Add list_products route handler with CSRF auth - Create useProducts hook with loading/error states - Export Product type and hook from @moneydevkit/nextjs
Resolve dependency version conflicts: - Keep @moneydevkit/api-contract ^0.1.14 (needed for useProducts feature) - Update @moneydevkit/lightning-js to ^0.1.60 (from main)
|
@codex Review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ad8a047b98
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex Review |
|
Codex Review: Didn't find any major issues. You're on a roll. ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
- Update packages/core to use prices?.[0] instead of price - Align UnconfirmedCheckout.tsx with new schema - Update all packages to api-contract ^0.1.16
Show purchased products as line items inside the View Details collapsible section, with a separator before totals. Handles FREE, CUSTOM, and FIXED price types in both USD and SAT.
Updated comment for clarity regarding AMOUNT type fields.
martinsaposnic
left a comment
martinsaposnic
left a comment
There was a problem hiding this comment.
looks good overall. tiny change requested
Change CreateCheckoutParams from a loose interface with optional fields to a discriminated union that enforces correct field combinations: - AmountCheckoutParams: type: 'AMOUNT' with required amount field - ProductsCheckoutParams: type: 'PRODUCTS' with required products array This provides better TypeScript DX with autocomplete and prevents invalid combinations like passing both amount and products.
|
hmmm just realized this will won't be backwards compat, is there any way we can make it default to amount? if not, that's ok, but let's try to make it ergonomic |
martinsaposnic
left a comment
martinsaposnic
left a comment
There was a problem hiding this comment.
let's update the READMEs before sending it
2 participants
Summary
useProductshook for fetching organization products via APIDepends on: