Revert "fix(lsps4): track channel opens in flight to prevent stuck HTLC loop"

This reverts commit 1facb94.

Author: martinsaposnic

lightning-liquidity/src/lsps4/service.rs

@@ -101,7 +101,6 @@ where
 	scid_store: ScidStore<L, K>,
 	htlc_store: HTLCStore<L, K>,
 	connected_peers: RwLock<HashSet<PublicKey>>,
-	channel_opens_in_flight: RwLock<HashSet<PublicKey>>,
 	config: LSPS4ServiceConfig,
 }
 
@@ -129,7 +128,6 @@ where
 			config,
 			logger,
 			connected_peers: RwLock::new(HashSet::new()),
-			channel_opens_in_flight: RwLock::new(HashSet::new()),
 		})
 	}
 
@@ -277,8 +275,6 @@ where
 	pub fn channel_ready(
 		&self, counterparty_node_id: &PublicKey,
 	) -> Result<(), APIError> {
-		self.channel_opens_in_flight.write().unwrap().remove(counterparty_node_id);
-
 		let is_connected = self.is_peer_connected(counterparty_node_id);
 
 		log_info!(
@@ -474,8 +470,6 @@ where
 
 	/// Will update the set of connected peers
 	pub fn peer_disconnected(&self, counterparty_node_id: &PublicKey) {
-		self.channel_opens_in_flight.write().unwrap().remove(counterparty_node_id);
-
 		let (was_present, remaining_count) = {
 			let mut peers = self.connected_peers.write().unwrap();
 			let was = peers.remove(counterparty_node_id);
@@ -531,23 +525,16 @@ where
 				);
 				let actions = self.calculate_htlc_actions_for_peer(node_id, htlcs);
 				if actions.new_channel_needed_msat.is_some() {
-					let already_in_flight = self.channel_opens_in_flight.read().unwrap().contains(&node_id);
-					if already_in_flight {
-						log_info!(
-							self.logger,
-							"[LSPS4] process_pending_htlcs: peer {} needs a new channel, \
-							 skipping (channel open already in flight)",
-							node_id
-						);
-						continue;
-					}
+					// A channel open is already in flight from htlc_intercepted or
+					// peer_connected. Skip — channel_ready will handle forwarding
+					// once the new channel is established.
 					log_info!(
 						self.logger,
 						"[LSPS4] process_pending_htlcs: peer {} needs a new channel, \
-						 triggering OpenChannel",
+						 skipping (channel open already in flight)",
 						node_id
 					);
-					self.channel_opens_in_flight.write().unwrap().insert(node_id);
+					continue;
 				}
 				self.execute_htlc_actions(actions, node_id);
 			}