chore(poc): update PoC to use new WASM interface (SQL-3170)#8119
Open
nicholascioli wants to merge 1 commit into
Open
chore(poc): update PoC to use new WASM interface (SQL-3170)#8119nicholascioli wants to merge 1 commit into
nicholascioli wants to merge 1 commit into
Conversation
This commit updates the existing WASM PoC code to use the new interface introduced by the schema builder library work. Note that this will not work as is until the schema manager wasm bundle gets packaged and deployed to NPM.
Collaborator
|
Hi @nicholascioli, I understand the new lib is not published yet (I recall the plan was that we'd cover the publishing), but have you tested this with a linked package? If not I can try it out |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the existing WASM PoC code to use the new interface introduced by the schema builder library work.
Note that this will not work as is until the schema manager wasm bundle gets packaged and deployed to NPM.
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes