Skip to content

feat(query-bar): remove reset button COMPASS-10723#8124

Open
Anemy wants to merge 2 commits into
mainfrom
COMPASS-10723-remove-reset-button-on-query-bar
Open

feat(query-bar): remove reset button COMPASS-10723#8124
Anemy wants to merge 2 commits into
mainfrom
COMPASS-10723-remove-reset-button-on-query-bar

Conversation

@Anemy

@Anemy Anemy commented Jun 3, 2026

Copy link
Copy Markdown
Member

COMPASS-10723

before after
Screenshot 2026-06-03 at 08 45 21 Screenshot 2026-06-03 at 10 40 52

A few unrelated changes got grouped in from running npm run reformat in the packages and not on changed files. Happy to remove those if folks would prefer it.

Discussion in #devtools-design: https://mongodb.slack.com/archives/GDTJXPHD0/p1780508646159579
Telemetry of usage: https://mixpanel.com/s/2Zu6HI

Copilot AI review requested due to automatic review settings June 3, 2026 17:43
@Anemy Anemy requested a review from a team as a code owner June 3, 2026 17:43
@Anemy Anemy requested a review from alenakhineika June 3, 2026 17:43
@github-actions github-actions Bot added the feat label Jun 3, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the Query Bar “Reset” functionality across Compass UI surfaces (CRUD/Documents and Schema) and updates unit/e2e tests and supporting helpers accordingly.

Changes:

  • Removed the Reset button from the Query Bar UI and deleted the corresponding Redux action/reducer logic.
  • Propagated API surface changes by removing onReset* props from toolbars and consumers.
  • Updated e2e selectors/helpers and reformatted/adjusted various tests impacted by the UI change.

Reviewed changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
packages/compass-schema/src/index.ts Adds an ESLint suppression for a service locator type assertion.
packages/compass-schema/src/components/schema-toolbar.tsx Removes reset-related prop plumbing to Query Bar.
packages/compass-schema/src/components/schema-toolbar.spec.tsx Updates Schema toolbar tests to reflect removed reset prop.
packages/compass-schema/src/components/field.spec.tsx Updates Query Bar plugin mock setup formatting/types.
packages/compass-schema/src/components/compass-schema.tsx Stops passing reset handler into the Schema toolbar.
packages/compass-query-bar/src/stores/query-bar-reducer.ts Removes resetQuery thunk and ResetQuery action handling.
packages/compass-query-bar/src/stores/query-bar-reducer.spec.ts Removes reducer tests that asserted reset behavior.
packages/compass-query-bar/src/index.tsx Adds an ESLint suppression for a service locator type assertion.
packages/compass-query-bar/src/components/query-bar.tsx Removes Reset button rendering and related props/state mapping.
packages/compass-query-bar/src/components/query-bar.spec.tsx Updates component tests to no longer expect/reset via Reset.
packages/compass-query-bar/src/components/query-ai.spec.tsx Refactors test provider value object (format/type adjustments).
packages/compass-e2e-tests/tests/in-use-encryption.test.ts Minor type cleanup around includes() checks.
packages/compass-e2e-tests/helpers/selectors.ts Removes selector for the deleted Reset button.
packages/compass-e2e-tests/helpers/commands/run-find-operation.ts Removes reset-based idempotency helper tied to Reset button.
packages/compass-crud/test/render-with-query-bar.tsx Updates Query Bar plugin mock service setup formatting/types.
packages/compass-crud/src/stores/crud-store.spec.ts Minor type cleanup in event helper and FLE fallback test inputs.
packages/compass-crud/src/index.ts Adds an ESLint suppression for a service locator type assertion.
packages/compass-crud/src/components/table-view/document-table-view.tsx Removes unnecessary RowNode import/cast for refreshCells.
packages/compass-crud/src/components/table-view/document-table-view.spec.tsx Test refactor around querySelector results (needs typed element access).
packages/compass-crud/src/components/table-view/cell-editor.tsx Removes unnecessary RowNode cast for refreshCells.
packages/compass-crud/src/components/table-view/cell-editor.spec.tsx Test refactor around getByTestId results (needs typed input access).
packages/compass-crud/src/components/document-list.tsx Removes reset callback wiring into CRUD toolbar/query bar.
packages/compass-crud/src/components/crud-toolbar.tsx Removes reset-related prop plumbing to Query Bar.
packages/compass-crud/src/components/crud-toolbar.spec.tsx Updates toolbar tests to reflect removed reset prop.
packages/compass-crud/src/components/change-view/change-view.tsx Reduces unnecessary type assertions in change view rendering.

@alenakhineika

Copy link
Copy Markdown
Collaborator

We should probably add a telemetry event first to be sure it is not actively being used.

@Anemy

Anemy commented Jul 6, 2026

Copy link
Copy Markdown
Member Author

Event telemetry: https://mixpanel.com/s/2Zu6HI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants