fix(compass-indexes): fix margin for error banner and update search incompatible view ui COMPASS-10745#8160
Open
DarshanaVenkatesh wants to merge 11 commits into
Open
fix(compass-indexes): fix margin for error banner and update search incompatible view ui COMPASS-10745#8160DarshanaVenkatesh wants to merge 11 commits into
DarshanaVenkatesh wants to merge 11 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Compass Indexes UI behavior for views that are incompatible with Atlas Search, and adjusts toolbar layout/visibility to better handle error and “incompatible view” scenarios.
Changes:
- Tweaks the view pipeline incompatibility banner content gating to better match the “no search indexes” scenario.
- Adds a special-case empty-state path in the Search Indexes table for non-queryable view pipelines.
- Adjusts the indexes toolbar layout (flex + gap) and visibility logic, including wiring a
hasSearchIndexesderived prop from state.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/compass-indexes/src/components/view-incompatible-components/view-pipeline-incompatible-banner.tsx | Adjusts which banner header content is shown based on whether search indexes exist. |
| packages/compass-indexes/src/components/search-indexes-table/search-indexes-table.tsx | Adds a new empty-state branch for read-only views with non-queryable pipelines. |
| packages/compass-indexes/src/components/indexes-toolbar/indexes-toolbar.tsx | Updates toolbar container spacing and refines toolbar visibility rules using a new hasSearchIndexes prop. |
DarshanaVenkatesh
added
bug
no release notes
DarshanaVenkatesh
requested review from
a team,
paula-stacho and
pavithrachidambaram-afk
and removed request for
a team
paula-stacho
reviewed
Jul 8, 2026
| isVersionCompatible && | ||
| isSearchManagementActive && | ||
| (isViewPipelineSearchQueryable || isIncompatibleViewWithExistingIndexes); | ||
| const showToolbarButtons = !isReadonlyView || canManageSearchIndexesOnView; |
Collaborator
There was a problem hiding this comment.
This is getting hard to understand, perhaps it would be worth to separate this logic into a function, so that we can have early returns (for example for non views). And possibly comments 😊
Collaborator
Author
There was a problem hiding this comment.
Fair point, extracted into helper!
paula-stacho
reviewed
Jul 8, 2026
| variant={hasNoSearchIndexes ? 'warning' : 'danger'} | ||
| data-testid="view-not-search-compatible-banner" | ||
| > | ||
| {!hasNoSearchIndexes && ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For a search-incompatible view with no search indexes, hide the toolbar and show a "No standard indexes" empty state instead of a disabled create button.
Incompatible views that still have (failed) indexes keep current behavior of listing indexes w/ toolbar
Error w/ spacing
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes