feat(sidebar): group connections into colored groups#8210
Open
dshved wants to merge 10 commits into
Open
Conversation
…form - drop the description under the group color select so the personalization grid rows stay aligned - default the new group color to No Color instead of the first palette color - recolor the just-created group when the color select changes (creation happens as soon as the name is confirmed, so a color picked after that was silently ignored); expose an onUpdateGroup form setting for it - resolve the blur re-fire of the group combobox (which sends the displayed name, not the id) against persisted groups too, so selecting an existing group no longer creates a colorless duplicate - turn the select into a controlled "Group color" field: it mirrors the selected group's color and is disabled for pre-existing groups (their color is edited from the sidebar)
Expose the updateGroup action as the form's onUpdateGroup setting so the form can recolor a group it just created. Also type the track stub in the groups slice spec with createNoopTrack to fix the package typecheck.
Wrap the name and color fields in FormFieldContainer, matching how other Compass modals space their form fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for organizing saved connections into named, colored groups in the sidebar. The feature is gated behind the
enableConnectionGroupsfeature flag (development stage), so default behavior is unchanged.{ id, name, color? }persisted in a dedicatedConnectionGroupsFileUserData collection inconnection-storage(with IPC exposure), with agroupsRedux slice incompass-connections(load + CRUD).favorite.groupId.Checklist
Motivation and Context
Grouping helps users with many saved connections keep the sidebar organized (e.g. per project or environment) and visually distinguish groups by color. Solves the long-standing pain of a flat, unstructured connection list.
Note: as a community contributor I can't open a
New Featureissue in the public COMPASS Jira project (it only acceptsBug), so this PR has noCOMPASS-XXXXticket in its title; happy to add one if a maintainer files/links an internal ticket.Open Questions
Comboboxcomponent has a pre-existing quirk where its "Clear selection" button lackstype="button"and submits an enclosing form. It affects the group combobox too, but the fix belongs incompass-componentsand touches every consumer, so it's left as a follow-up rather than bundled here.Dependents
N/A
Types of changes