feat(compass-editor): add hover styling to autocomplete dropdown item COMPASS-8227#8223
Open
johnjackweir wants to merge 4 commits into
Open
feat(compass-editor): add hover styling to autocomplete dropdown item COMPASS-8227#8223johnjackweir wants to merge 4 commits into
johnjackweir wants to merge 4 commits into
Conversation
…COMPASS-8227 Add the same background color styling to autocomplete dropdown items on hover as appears when navigating with arrow keys (aria-selected state). Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
…OMPASS-8227 Use EditorView.baseTheme to apply hover styles to autocomplete dropdown items. This ensures styles apply to tooltips rendered at document root level. Remove ineffective test that couldn't verify hover pseudo-class behavior. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
…OMPASS-8227 Add test to verify that autocomplete hover styles from EditorView.baseTheme are properly injected into the document. The test checks for the presence of hover styling in the generated style tags. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
…OMPASS-8227 Remove redundant hover styles from getStylesForTheme since they don't work for tooltips rendered at document root. The autocompleteHoverStyles using EditorView.baseTheme is the correct approach and is already in place. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
johnjackweir
force-pushed
the
COMPASS-8227
branch
from
8da2622 to
935aec6
Compare
Collaborator
Author
|
Confirmed this works, ex when hovering "text" value in the dropdown in old and new |
johnjackweir
commented
Jul 8, 2026
| ); | ||
| }); | ||
|
|
||
| it('configures autocomplete hover styles', function () { |
Collaborator
Author
There was a problem hiding this comment.
This test is kinda dumb so open to removing it 🪓
you can't actually trigger CSS :hover pseudo-classes in a test environment (they
only work with real mouse interaction) so this test verifies the next best thing: that
the CSS rules defining the hover behavior are present in the document and will be
applied when users actually hover in the browser
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
COMPASS-8227
Add the same background color styling to autocomplete dropdown items on hover as appears when navigating with arrow keys (aria-selected state).
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes