[DO NOT MERGE] Mcp 538 no express#1272
Draft
manupedrozo wants to merge 4 commits into
Draft
Conversation
Stand up the wrapper package's offline test tiers, reusing the repo's Vitest setup (auto-discovered by the existing run-tests CI job, no workflow change): - Unit scaffold (tokenManager.test.ts) — network-mocked, it.todo for MCP-539. - Integration harness: an in-process fake remote MCP server (src/testHelpers/fakeRemote.ts, excluded from dist) driven via the MCP SDK client over a spawned wrapper (WRAPPER_CLI_PATH override); one live sanity test plus it.todo scenarios for MCP-539. - Add @modelcontextprotocol/sdk, express, @types/express devDeps + pretest compile so dist/cli.js exists for the harness. - Document wrapper unit/integration testing in CONTRIBUTING.md. Builds and runs green without any wrapper logic (cli.ts is still a stub).
…upport SSE+JSON (MCP-538) - Rename the test double from 'fake' to 'mock' (file, type, function, literals). - Rewrite comments in plain language; add a reason to the eslint-disable. - Mock remote now defaults to SSE (matching cloud-dev per MCP-542) with a responseMode: 'json' option; notifications return 202.
Replace the ASCII diagram with a short verbal description of how the integration tests are wired.
manupedrozo
force-pushed
the
MCP-538-no-express
branch
from
0bc4db5 to
c97c24f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick branch to see if we can implement mocks using Node's built-in http package instead of express.
See #1268