chore: Add token manager and config unit tests MCP-539#1287
Merged
Conversation
manupedrozo
force-pushed
the
MCP-539-unit-tests
branch
from
81a8d84 to
51e57ec
Compare
manupedrozo
force-pushed
the
MCP-539-unit-tests
branch
from
51e57ec to
b910af1
Compare
manupedrozo
requested review from
fmenezes,
gagik and
jeroenvervaeke
and removed request for
a team and
jeroenvervaeke
blva
approved these changes
Jun 26, 2026
maastha
reviewed
Jun 26, 2026
| }); | ||
|
|
||
| describe("error cases", () => { | ||
| it("throws TokenError with the HTTP status code on a non-OK response", async () => { |
Collaborator
There was a problem hiding this comment.
Since the remote-server 401 → invalidate → retry path lives in the SDK transport, I don't think we can meaningfully unit-test it from the wrapper side — would it be possible to have that covered in the integ/e2e PR?
Collaborator
Author
There was a problem hiding this comment.
Yes, we'll cover it in integ tests
maastha
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding unit tests for the mcp wrapper package.
Integ tests and e2e tests to be covered in a separate PR.
Ticket: MCP-539