INTPYTHON-935 Fix NotSupportedError for StringAgg(..., distinct=True)

Author: timgraham

django_mongodb_backend/aggregates.py

@@ -86,7 +86,7 @@ def stddev_variance(self, compiler, connection):
     return aggregate(self, compiler, connection, operator=operator)
 
 
-def string_agg(self, compiler, connection):  # noqa: ARG001
+def string_agg(self, compiler, connection, resolve_inner_expression=False):  # noqa: ARG001
     raise NotSupportedError("StringAgg is not supported.")
 
 

docs/releases/6.0.x.rst

@@ -35,8 +35,9 @@ Bug fixes
   that references in migrations don't need to be adjusted if models are later
   removed.
 
-- Added a helpful ``NotSupportedError`` for ``QuerySet.extra(where=...)``
-  rather than crashing with a more obscure exception.
+- Added a helpful ``NotSupportedError`` for ``QuerySet.extra(where=...)`` and
+  ``StringAgg(..., distinct=True)`` rather than crashing with more obscure
+  exceptions.
 
 Deprecated features
 -------------------

tests/aggregation_/test_stringagg.py

@@ -9,3 +9,13 @@ class StringAggTests(TestCase):
     def test_not_supprted(self):
         with self.assertRaisesMessage(NotSupportedError, "StringAgg is not supported."):
             list(Author.objects.aggregate(all_names=StringAgg("name", Value(","))))
+
+    def test_distinct(self):
+        with self.assertRaisesMessage(NotSupportedError, "StringAgg is not supported."):
+            Author.objects.aggregate(
+                stringagg=StringAgg(
+                    "name",
+                    delimiter=Value(";"),
+                    distinct=True,
+                )
+            )