INTPYTHON-945 Make creating models with expressions raise NotSupportedError

Author: timgraham

django_mongodb_backend/compiler.py

@@ -920,7 +920,12 @@ def execute_sql(self, returning_fields=None):
                     raise IntegrityError(
                         f"You can't set {field.name} (a non-nullable field) to None."
                     )
-
+                if hasattr(value, "as_mql"):
+                    raise NotSupportedError(
+                        f"MongoDB does not support creating models with "
+                        f"expressions: got {value} for field {field.name}."
+                        # % You can't set {field.name} (a non-nullable field) to None."
+                    )
                 field_values[field.column] = value
             objs.append(field_values)
         return self.insert(objs, returning_fields=returning_fields)

django_mongodb_backend/features.py

@@ -137,19 +137,6 @@ def django_test_expected_failures(self):
             "schema.tests.SchemaTests.test_rename_keep_db_default",
             "validation.test_unique.PerformUniqueChecksTest.test_unique_db_default",
         },
-        "Insert expressions aren't supported.": {
-            "basic.tests.ModelTest.test_save_expressions",
-            "bulk_create.tests.BulkCreateTests.test_bulk_insert_now",
-            "bulk_create.tests.BulkCreateTests.test_bulk_insert_expressions",
-            "expressions.tests.BasicExpressionsTests.test_new_object_create",
-            "expressions.tests.BasicExpressionsTests.test_new_object_save",
-            "expressions.tests.BasicExpressionsTests.test_object_create_with_aggregate",
-            "expressions.tests.BasicExpressionsTests.test_object_create_with_f_expression_in_subquery",
-            "expressions.tests.BasicExpressionsTests.test_object_update_unsaved_objects",
-            # PI()
-            "db_functions.math.test_round.RoundTests.test_decimal_with_precision",
-            "db_functions.math.test_round.RoundTests.test_float_with_precision",
-        },
         "MongoDB doesn't rename an index when a field is renamed.": {
             "migrations.test_operations.OperationTests.test_rename_field_index_together",
             "migrations.test_operations.OperationTests.test_rename_field_unique_together",
@@ -480,6 +467,24 @@ def django_test_skips(self):
 
     # Tests that are expected to raise certain exceptions:
     _django_test_expected_raises = {
+        (
+            NotSupportedError,
+            "MongoDB does not support creating models with expressions: got "
+            "Now() for field pub_date.",
+        ): {
+            "basic.tests.ModelTest.test_save_expressions",
+        },
+        (NotSupportedError, "MongoDB does not support creating models with expressions"): {
+            "bulk_create.tests.BulkCreateTests.test_bulk_insert_now",
+            "bulk_create.tests.BulkCreateTests.test_bulk_insert_expressions",
+            "expressions.tests.BasicExpressionsTests.test_new_object_create",
+            "expressions.tests.BasicExpressionsTests.test_new_object_save",
+            "expressions.tests.BasicExpressionsTests.test_object_create_with_aggregate",
+            "expressions.tests.BasicExpressionsTests.test_object_create_with_f_expression_in_subquery",
+            "expressions.tests.BasicExpressionsTests.test_object_update_unsaved_objects",
+            "db_functions.math.test_round.RoundTests.test_decimal_with_precision",
+            "db_functions.math.test_round.RoundTests.test_float_with_precision",
+        },
         (NotSupportedError, "Pattern lookups on UUIDField are not supported."): {
             "model_fields.test_uuid.TestQuerying.test_contains",
             "model_fields.test_uuid.TestQuerying.test_endswith",

docs/releases/6.0.x.rst

@@ -15,7 +15,7 @@ New features
 Bug fixes
 ---------
 
-- ...
+- Made creating models with expressions raise a helpful error message.
 
 6.0.3
 =====