INTPYTHON-929 Encrypted collection existence check (🤖 assisted)#502
Closed
aclark4life wants to merge 2 commits into
Closed
INTPYTHON-929 Encrypted collection existence check (🤖 assisted)#502aclark4life wants to merge 2 commits into
aclark4life wants to merge 2 commits into
Conversation
Optimize the encrypted field validation by caching collection existence checks. Previously, every insert operation for models with encrypted fields would call table_names() to verify the collection exists. Now, the check is performed once per collection and cached for subsequent inserts. Changes: - Add _verified_encrypted_collections cache set to DatabaseWrapper - Check cache before calling table_names() in SQLInsertCompiler.insert() - Populate cache when creating encrypted collections in schema editor - Add test to verify caching behavior works correctly This reduces database calls from N (one per insert) to 1 (one per collection) while maintaining the same safety guarantee against unencrypted collection auto-creation.
Remove unittest.mock usage and test the cache behavior directly by checking the _verified_encrypted_collections set before and after inserts. This follows the pattern used in other encryption tests.
aclark4life
changed the title
aclark4life
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimize the encrypted field validation by caching collection existence checks. Previously, every insert operation for models with encrypted fields would call table_names() to verify the collection exists. Now, the check is performed once per collection and cached for subsequent inserts.
Changes:
This reduces database calls from N (one per insert) to 1 (one per collection) while maintaining the same safety guarantee against unencrypted collection auto-creation.