INTPYTHON-935 Added NotSupportedError for QuerySet.extra(where=...)#507
Merged
Conversation
aclark4life
approved these changes
Mar 17, 2026
aclark4life
left a comment
aclark4life
left a comment
Collaborator
There was a problem hiding this comment.
If appropriate and although it may already be obvious, it might be nice to call out that extra is unsupported and that where should have already raised NotSupportedError, otherwise LGTM.
Collaborator
Author
|
In the release note? That's what I tried to convey by saying, "(rather than raising NotSupportedError)" |
timgraham
force-pushed
the
extrawhere-crash
branch
from
March 17, 2026 01:06
b087d33 to
0e1d185
Compare
timgraham
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.