Disable performance tests on pull requests#540
Merged
Conversation
Collaborator
Author
|
This approach isn't correct because it won't allow the tests to be triggered on a PR manually (for example, when new performance benchmarks are added). Instead, we might follow the "pr" tag approach that the mongodb-python-driver evergreen config uses. |
Collaborator
Author
|
I think we should merge this and revisit it later if a more elegant solution seems justified. I've updated the commit message and PR description with my rationale. |
timgraham
force-pushed
the
disable-performance-tests
branch
from
3547c90 to
b26ad85
Compare
This approach isn't ideal because it won't allow the tests to be triggered on a PR manually (for example, when new benchmarks are added). Instead, we might follow the "pr" tag approach that the mongodb-python-driver Evergreen config uses. However, I think we should revisit this later if that solution seems justified. Temporarily reverting this patch in a PR branch may work to check the performance tests there if need be. Evergreen shows ~$0.30 is wasted when this job runs on a PR since the results aren't used.
timgraham
force-pushed
the
disable-performance-tests
branch
from
b26ad85 to
ac81d20
Compare
aclark4life
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This approach isn't ideal because it won't allow the tests to be triggered on a PR manually (for example, when new benchmarks are added). Instead, we might follow the "pr" tag approach that the mongodb-python-driver Evergreen config uses.
However, I think we should revisit this later if that solution seems justified. Temporarily reverting this patch in a PR branch may work to check the performance tests there if need be. Evergreen shows we waste $0.30 each time this job runs on a PR since the results aren't used. For comparison, running the non-performance tests costs about $0.20 total.