MONGOCRYPT-833 fix bounds check (#1049)

kevinAlbs · web-flow · commit cbc3f559aab4 · 2025-08-07T20:20:37.000-04:00
Fixes Coverity issue: 175729
diff --git a/kms-message/src/kms_kmip_reader_writer.c b/kms-message/src/kms_kmip_reader_writer.c
@@ -205,7 +205,7 @@ kmip_writer_begin_struct (kmip_writer_t *writer, kmip_tag_type_t tag)
    size_t pos = writer->buffer->len;
 
    kmip_writer_write_u32 (writer, 0);
-   KMS_ASSERT(writer->cur_pos < MAX_KMIP_WRITER_POSITIONS);
+   KMS_ASSERT(writer->cur_pos < MAX_KMIP_WRITER_POSITIONS - 1);
    writer->cur_pos++;
    writer->positions[writer->cur_pos] = pos;
 }

Original file line number	Diff line number	Diff line change
`@@ -205,7 +205,7 @@ kmip_writer_begin_struct (kmip_writer_t *writer, kmip_tag_type_t tag)`
`205`	`205`	`size_t pos = writer->buffer->len;`
`206`	`206`
`207`	`207`	`kmip_writer_write_u32 (writer, 0);`
`208`		`- KMS_ASSERT(writer->cur_pos < MAX_KMIP_WRITER_POSITIONS);`
	`208`	`+ KMS_ASSERT(writer->cur_pos < MAX_KMIP_WRITER_POSITIONS - 1);`
`209`	`209`	`writer->cur_pos++;`
`210`	`210`	`writer->positions[writer->cur_pos] = pos;`
`211`	`211`	`}`