CDRIVER-6274 finalize client backpressure phase 1 rollout#2269
Merged
connorsmacd merged 19 commits intomongodb:masterfrom Apr 15, 2026
Merged
Conversation
121b4fb to
340315d
Compare
connorsmacd
commented
Apr 13, 2026
kevinAlbs
reviewed
Apr 14, 2026
Collaborator
kevinAlbs
left a comment
There was a problem hiding this comment.
Changes look good with an added check for URI value of 0.
The Evergreen task failures look unrelated to these changes. The "Incorrect shasum256" on Windows 7.0 tasks is reported on SERVER-124033.
eramongodb
reviewed
Apr 14, 2026
eramongodb
approved these changes
Apr 14, 2026
Contributor
eramongodb
left a comment
There was a problem hiding this comment.
Minor suggestion; otherwise, LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CDRIVER-6274
DRIVERS-3427
Summary
This PR implement phase 1 Client Backpressure spec changes per DRIVERS-3427:
adaptiveRetriesURI option and token bucket. While the token bucket may be resurrected in the future, this is not a guarantee, so I removed it completely.maxAdaptiveRetriesURI option (non-negative integer, default2) to configure the maximum number of retries for operations that fail with aSystemOverloadedError.enableOverloadRetargetingURI option (boolean, defaultfalse) to control whether the driver deprioritizes a server that returns aSystemOverloadedErrorwhen selecting a server for retry.