Skip to content

CDRIVER-6274 finalize client backpressure phase 1 rollout#2269

Merged
connorsmacd merged 19 commits intomongodb:masterfrom
connorsmacd:finalize-backpressure-phase-1.CDRIVER-6274
Apr 15, 2026
Merged

CDRIVER-6274 finalize client backpressure phase 1 rollout#2269
connorsmacd merged 19 commits intomongodb:masterfrom
connorsmacd:finalize-backpressure-phase-1.CDRIVER-6274

Conversation

@connorsmacd
Copy link
Copy Markdown
Collaborator

@connorsmacd connorsmacd commented Apr 13, 2026

CDRIVER-6274
DRIVERS-3427

Summary

This PR implement phase 1 Client Backpressure spec changes per DRIVERS-3427:

  • Remove the adaptiveRetries URI option and token bucket. While the token bucket may be resurrected in the future, this is not a guarantee, so I removed it completely.
  • Add maxAdaptiveRetries URI option (non-negative integer, default 2) to configure the maximum number of retries for operations that fail with a SystemOverloadedError.
  • Add enableOverloadRetargeting URI option (boolean, default false) to control whether the driver deprioritizes a server that returns a SystemOverloadedError when selecting a server for retry.
  • Update prose and unified tests.

@connorsmacd connorsmacd changed the title CDRIVER-3427 finalize client backpressure phase 1 rollout CDRIVER-6274 finalize client backpressure phase 1 rollout Apr 13, 2026
@connorsmacd connorsmacd force-pushed the finalize-backpressure-phase-1.CDRIVER-6274 branch from 121b4fb to 340315d Compare April 13, 2026 14:04
Comment thread NEWS
@connorsmacd connorsmacd marked this pull request as ready for review April 13, 2026 16:56
@connorsmacd connorsmacd requested a review from a team as a code owner April 13, 2026 16:57
Copy link
Copy Markdown
Collaborator

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good with an added check for URI value of 0.

The Evergreen task failures look unrelated to these changes. The "Incorrect shasum256" on Windows 7.0 tasks is reported on SERVER-124033.

Comment thread src/libmongoc/src/mongoc/mongoc-client.c Outdated
Comment thread src/libmongoc/doc/mongoc_uri_t.rst Outdated
Comment thread NEWS Outdated
Comment thread src/libmongoc/src/mongoc/mongoc-retryable-cmd.c
Copy link
Copy Markdown
Contributor

@eramongodb eramongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion; otherwise, LGTM.

Comment thread src/libmongoc/src/mongoc/mongoc-retry-backoff-generator.c Outdated
Copy link
Copy Markdown
Collaborator

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@connorsmacd connorsmacd merged commit 6da116d into mongodb:master Apr 15, 2026
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants