tweak tests to actually test the right return branch

Author: kyra-rk

tests/MongoDB.Driver.Tests/Core/Configuration/ConnectionSettingsTests.cs

@@ -70,7 +70,7 @@ public void constructor_should_throw_when_maxIdleTime_is_negative()
         }
 
         [Fact]
-        public void constructor_with_maxIdleTime_of_zero_should_return_expected_result()
+        public void constructor_should_not_throw_when_maxIdleTime_is_zero()
         {
             var subject = new ConnectionSettings(maxIdleTime: TimeSpan.FromSeconds(0));
             subject.MaxIdleTime.Should().Be(TimeSpan.Zero);

tests/MongoDB.Driver.Tests/Core/Connections/BinaryConnectionTests.cs

@@ -728,7 +728,7 @@ public void IsExpired_should_return_false_when_maxIdleTime_has_no_limit()
                 socketReadTimeout: TimeSpan.FromMilliseconds(1000),
                 socketWriteTimeout: TimeSpan.FromMilliseconds(1000));
 
-            subject.Open(OperationContext.NoTimeout);
+            subject.Open(OperationContext.NoTimeout); // Open so that we don't return early in IsExpired
             subject.IsExpired.Should().BeFalse();
         }
 
@@ -738,7 +738,7 @@ public void IsExpired_should_return_true_when_maxIdleTime_is_exceeded()
             var subject = new BinaryConnection(
                 serverId: _serverId,
                 endPoint: _endPoint,
-                settings: new ConnectionSettings(maxIdleTime: TimeSpan.FromMilliseconds(10)),
+                settings: new ConnectionSettings(maxIdleTime: TimeSpan.FromMilliseconds(10), maxLifeTime: TimeSpan.FromMinutes(10)),
                 streamFactory: _mockStreamFactory.Object,
                 connectionInitializer: _mockConnectionInitializer.Object,
                 eventSubscriber: _capturedEvents,
@@ -748,7 +748,7 @@ public void IsExpired_should_return_true_when_maxIdleTime_is_exceeded()
                 socketWriteTimeout: TimeSpan.FromMilliseconds(1000));
 
             subject.Open(OperationContext.NoTimeout);
-            Thread.Sleep(20);
+            Thread.Sleep(200);
             subject.IsExpired.Should().BeTrue();
         }